error.test.js
15.4 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
'use strict';
const chai = require('chai'),
sinon = require('sinon'),
expect = chai.expect,
Support = require('./support'),
Sequelize = Support.Sequelize;
describe(Support.getTestDialectTeaser('Sequelize Errors'), () => {
describe('API Surface', () => {
it('Should have the Error constructors exposed', () => {
expect(Sequelize).to.have.property('Error');
expect(Sequelize).to.have.property('ValidationError');
expect(Sequelize).to.have.property('OptimisticLockError');
});
it('Sequelize Errors instances should be instances of Error', () => {
const error = new Sequelize.Error();
const errorMessage = 'error message';
const validationError = new Sequelize.ValidationError(errorMessage, [
new Sequelize.ValidationErrorItem('<field name> cannot be null', 'notNull Violation', '<field name>', null),
new Sequelize.ValidationErrorItem('<field name> cannot be an array or an object', 'string violation', '<field name>', null)
]);
const optimisticLockError = new Sequelize.OptimisticLockError();
expect(error).to.be.instanceOf(Sequelize.Error);
expect(error).to.be.instanceOf(Error);
expect(error).to.have.property('name', 'SequelizeBaseError');
expect(validationError).to.be.instanceOf(Sequelize.ValidationError);
expect(validationError).to.be.instanceOf(Error);
expect(validationError).to.have.property('name', 'SequelizeValidationError');
expect(validationError.message).to.equal(errorMessage);
expect(optimisticLockError).to.be.instanceOf(Sequelize.OptimisticLockError);
expect(optimisticLockError).to.be.instanceOf(Error);
expect(optimisticLockError).to.have.property('name', 'SequelizeOptimisticLockError');
});
it('SequelizeValidationError should find errors by path', () => {
const errorItems = [
new Sequelize.ValidationErrorItem('invalid', 'type', 'first_name', null),
new Sequelize.ValidationErrorItem('invalid', 'type', 'last_name', null)
];
const validationError = new Sequelize.ValidationError('Validation error', errorItems);
expect(validationError).to.have.property('get');
expect(validationError.get).to.be.a('function');
const matches = validationError.get('first_name');
expect(matches).to.be.instanceOf(Array);
expect(matches).to.have.lengthOf(1);
expect(matches[0]).to.have.property('message', 'invalid');
});
it('SequelizeValidationError should override message property when message parameter is specified', () => {
const errorItems = [
new Sequelize.ValidationErrorItem('invalid', 'type', 'first_name', null),
new Sequelize.ValidationErrorItem('invalid', 'type', 'last_name', null)
],
customErrorMessage = 'Custom validation error message',
validationError = new Sequelize.ValidationError(customErrorMessage, errorItems);
expect(validationError).to.have.property('name', 'SequelizeValidationError');
expect(validationError.message).to.equal(customErrorMessage);
});
it('SequelizeValidationError should concatenate an error messages from given errors if no explicit message is defined', () => {
const errorItems = [
new Sequelize.ValidationErrorItem('<field name> cannot be null', 'notNull Violation', '<field name>', null),
new Sequelize.ValidationErrorItem('<field name> cannot be an array or an object', 'string violation', '<field name>', null)
],
validationError = new Sequelize.ValidationError(null, errorItems);
expect(validationError).to.have.property('name', 'SequelizeValidationError');
expect(validationError.message).to.match(/notNull Violation: <field name> cannot be null,\nstring violation: <field name> cannot be an array or an object/);
});
it('SequelizeValidationErrorItem does not require instance & validator constructor parameters', () => {
const error = new Sequelize.ValidationErrorItem('error!', null, 'myfield');
expect(error).to.be.instanceOf(Sequelize.ValidationErrorItem);
});
it('SequelizeValidationErrorItem should have instance, key & validator properties when given to constructor', () => {
const inst = { foo: 'bar' };
const vargs = [4];
const error = new Sequelize.ValidationErrorItem('error!', 'FUNCTION', 'foo', 'bar', inst, 'klen', 'len', vargs);
expect(error).to.have.property('instance');
expect(error.instance).to.equal(inst);
expect(error).to.have.property('validatorKey', 'klen');
expect(error).to.have.property('validatorName', 'len');
expect(error).to.have.property('validatorArgs', vargs);
});
it('SequelizeValidationErrorItem.getValidatorKey() should return a string', () => {
const error = new Sequelize.ValidationErrorItem('error!', 'FUNCTION', 'foo', 'bar', null, 'klen', 'len', [4]);
expect(error).to.have.property('getValidatorKey');
expect(error.getValidatorKey).to.be.a('function');
expect(error.getValidatorKey()).to.equal('function.klen');
expect(error.getValidatorKey(false)).to.equal('klen');
expect(error.getValidatorKey(0)).to.equal('klen');
expect(error.getValidatorKey(1, ':')).to.equal('function:klen');
expect(error.getValidatorKey(true, '-:-')).to.equal('function-:-klen');
const empty = new Sequelize.ValidationErrorItem('error!', 'FUNCTION', 'foo', 'bar');
expect(empty.getValidatorKey()).to.equal('');
expect(empty.getValidatorKey(false)).to.equal('');
expect(empty.getValidatorKey(0)).to.equal('');
expect(empty.getValidatorKey(1, ':')).to.equal('');
expect(empty.getValidatorKey(true, '-:-')).to.equal('');
});
it('SequelizeValidationErrorItem.getValidatorKey() should throw if namespace separator is invalid (only if NS is used & available)', () => {
const error = new Sequelize.ValidationErrorItem('error!', 'FUNCTION', 'foo', 'bar', null, 'klen', 'len', [4]);
expect(() => error.getValidatorKey(false, {})).to.not.throw();
expect(() => error.getValidatorKey(false, [])).to.not.throw();
expect(() => error.getValidatorKey(false, null)).to.not.throw();
expect(() => error.getValidatorKey(false, '')).to.not.throw();
expect(() => error.getValidatorKey(false, false)).to.not.throw();
expect(() => error.getValidatorKey(false, true)).to.not.throw();
expect(() => error.getValidatorKey(false, undefined)).to.not.throw();
expect(() => error.getValidatorKey(true, undefined)).to.not.throw(); // undefined will trigger use of function parameter default
expect(() => error.getValidatorKey(true, {})).to.throw(Error);
expect(() => error.getValidatorKey(true, [])).to.throw(Error);
expect(() => error.getValidatorKey(true, null)).to.throw(Error);
expect(() => error.getValidatorKey(true, '')).to.throw(Error);
expect(() => error.getValidatorKey(true, false)).to.throw(Error);
expect(() => error.getValidatorKey(true, true)).to.throw(Error);
});
it('SequelizeValidationErrorItem should map deprecated "type" values to new "origin" values', () => {
const data = {
'notNull Violation': 'CORE',
'string violation': 'CORE',
'unique violation': 'DB',
'Validation error': 'FUNCTION'
};
Object.keys(data).forEach(k => {
const error = new Sequelize.ValidationErrorItem('error!', k, 'foo', null);
expect(error).to.have.property('origin', data[k]);
expect(error).to.have.property('type', k);
});
});
it('SequelizeValidationErrorItem.Origins is valid', () => {
const ORIGINS = Sequelize.ValidationErrorItem.Origins;
expect(ORIGINS).to.have.property('CORE', 'CORE');
expect(ORIGINS).to.have.property('DB', 'DB');
expect(ORIGINS).to.have.property('FUNCTION', 'FUNCTION');
});
it('SequelizeDatabaseError should keep original message', () => {
const orig = new Error('original database error message');
const databaseError = new Sequelize.DatabaseError(orig);
expect(databaseError).to.have.property('parent');
expect(databaseError).to.have.property('original');
expect(databaseError.name).to.equal('SequelizeDatabaseError');
expect(databaseError.message).to.equal('original database error message');
});
it('ConnectionError should keep original message', () => {
const orig = new Error('original connection error message');
const connectionError = new Sequelize.ConnectionError(orig);
expect(connectionError).to.have.property('parent');
expect(connectionError).to.have.property('original');
expect(connectionError.name).to.equal('SequelizeConnectionError');
expect(connectionError.message).to.equal('original connection error message');
});
it('ConnectionRefusedError should keep original message', () => {
const orig = new Error('original connection error message');
const connectionError = new Sequelize.ConnectionRefusedError(orig);
expect(connectionError).to.have.property('parent');
expect(connectionError).to.have.property('original');
expect(connectionError.name).to.equal('SequelizeConnectionRefusedError');
expect(connectionError.message).to.equal('original connection error message');
});
it('AccessDeniedError should keep original message', () => {
const orig = new Error('original connection error message');
const connectionError = new Sequelize.AccessDeniedError(orig);
expect(connectionError).to.have.property('parent');
expect(connectionError).to.have.property('original');
expect(connectionError.name).to.equal('SequelizeAccessDeniedError');
expect(connectionError.message).to.equal('original connection error message');
});
it('HostNotFoundError should keep original message', () => {
const orig = new Error('original connection error message');
const connectionError = new Sequelize.HostNotFoundError(orig);
expect(connectionError).to.have.property('parent');
expect(connectionError).to.have.property('original');
expect(connectionError.name).to.equal('SequelizeHostNotFoundError');
expect(connectionError.message).to.equal('original connection error message');
});
it('HostNotReachableError should keep original message', () => {
const orig = new Error('original connection error message');
const connectionError = new Sequelize.HostNotReachableError(orig);
expect(connectionError).to.have.property('parent');
expect(connectionError).to.have.property('original');
expect(connectionError.name).to.equal('SequelizeHostNotReachableError');
expect(connectionError.message).to.equal('original connection error message');
});
it('InvalidConnectionError should keep original message', () => {
const orig = new Error('original connection error message');
const connectionError = new Sequelize.InvalidConnectionError(orig);
expect(connectionError).to.have.property('parent');
expect(connectionError).to.have.property('original');
expect(connectionError.name).to.equal('SequelizeInvalidConnectionError');
expect(connectionError.message).to.equal('original connection error message');
});
it('ConnectionTimedOutError should keep original message', () => {
const orig = new Error('original connection error message');
const connectionError = new Sequelize.ConnectionTimedOutError(orig);
expect(connectionError).to.have.property('parent');
expect(connectionError).to.have.property('original');
expect(connectionError.name).to.equal('SequelizeConnectionTimedOutError');
expect(connectionError.message).to.equal('original connection error message');
});
});
describe('Constraint error', () => {
[
{
type: 'UniqueConstraintError',
exception: Sequelize.UniqueConstraintError
},
{
type: 'ValidationError',
exception: Sequelize.ValidationError
}
].forEach(constraintTest => {
it('Can be intercepted as ' + constraintTest.type + ' using .catch', function() {
const spy = sinon.spy(),
User = this.sequelize.define('user', {
first_name: {
type: Sequelize.STRING,
unique: 'unique_name'
},
last_name: {
type: Sequelize.STRING,
unique: 'unique_name'
}
});
const record = { first_name: 'jan', last_name: 'meier' };
return this.sequelize.sync({ force: true }).bind(this).then(() => {
return User.create(record);
}).then(() => {
return User.create(record).catch(constraintTest.exception, spy);
}).then(() => {
expect(spy).to.have.been.calledOnce;
});
});
});
it('Supports newlines in keys', function() {
const spy = sinon.spy(),
User = this.sequelize.define('user', {
name: {
type: Sequelize.STRING,
unique: 'unique \n unique'
}
});
return this.sequelize.sync({ force: true }).then(() => {
return User.create({ name: 'jan' });
}).then(() => {
// If the error was successfully parsed, we can catch it!
return User.create({ name: 'jan' }).catch(Sequelize.UniqueConstraintError, spy);
}).then(() => {
expect(spy).to.have.been.calledOnce;
});
});
it('Works when unique keys are not defined in sequelize', function() {
let User = this.sequelize.define('user', {
name: {
type: Sequelize.STRING,
unique: 'unique \n unique'
}
}, { timestamps: false });
return this.sequelize.sync({ force: true }).then(() => {
// Now let's pretend the index was created by someone else, and sequelize doesn't know about it
User = this.sequelize.define('user', {
name: Sequelize.STRING
}, { timestamps: false });
return User.create({ name: 'jan' });
}).then(() => {
// It should work even though the unique key is not defined in the model
return expect(User.create({ name: 'jan' })).to.be.rejectedWith(Sequelize.UniqueConstraintError);
}).then(() => {
// And when the model is not passed at all
return expect(this.sequelize.query('INSERT INTO users (name) VALUES (\'jan\')')).to.be.rejectedWith(Sequelize.UniqueConstraintError);
});
});
it('adds parent and sql properties', function() {
const User = this.sequelize.define('user', {
name: {
type: Sequelize.STRING,
unique: 'unique'
}
}, { timestamps: false });
return this.sequelize.sync({ force: true })
.then(() => {
return User.create({ name: 'jan' });
}).then(() => {
// Unique key
return expect(User.create({ name: 'jan' })).to.be.rejected;
}).then(error => {
expect(error).to.be.instanceOf(Sequelize.UniqueConstraintError);
expect(error).to.have.property('parent');
expect(error).to.have.property('original');
expect(error).to.have.property('sql');
return User.create({ id: 2, name: 'jon' });
}).then(() => {
// Primary key
return expect(User.create({ id: 2, name: 'jon' })).to.be.rejected;
}).then(error => {
expect(error).to.be.instanceOf(Sequelize.UniqueConstraintError);
expect(error).to.have.property('parent');
expect(error).to.have.property('original');
expect(error).to.have.property('sql');
});
});
});
});