Merge pull request #182 from vlmonk/sqlite-quite-bug

fixed quotation for sqlite

lib/dialects/sqlite/query-generator.js

 var Utils = require("../../utils")
   , util  = require("util")
 
+var escape = function(str) {
+  if (typeof str == 'string') {
+    return "'" + str.replace(/'/g, "''") + "'";
+  } else {
+    return str;
+  }
+};
+
 module.exports = (function() {
   var QueryGenerator = {
     createTableQuery: function(tableName, attributes, options) {
@@ -42,13 +50,26 @@ module.exports = (function() {
             value = value ? 1 : 0;
           }
 
-          return Utils.escape((value instanceof Date) ? Utils.toSqlDate(value) : value)
+          return escape((value instanceof Date) ? Utils.toSqlDate(value) : value)
         }).join(",")
       }
 
       return Utils._.template(query)(replacements)
     },
 
+    updateQuery: function(tableName, values, where) {
+      var query = "UPDATE <%= table %> SET <%= values %> WHERE <%= where %>"
+      var replacements = {
+        table: Utils.addTicks(tableName),
+        values: Utils._.map(values, function(value, key){
+          return Utils.addTicks(key) + "=" + escape((value instanceof Date) ? Utils.toSqlDate(value) : value)
+        }).join(","),
+        where: MySqlQueryGenerator.getWhereConditions(where)
+      }
+
+      return Utils._.template(query)(replacements)
+    },
+
     deleteQuery: function(tableName, where, options) {
       options = options || {}
 

spec-jasmine/sqlite/query-generator.spec.js

+var Sequelize      = require("../../index")
+  , sequelize      = new Sequelize(null, null, null, { dialect: 'sqlite' })
+  , Helpers        = new (require("../config/helpers"))(sequelize)
+  , QueryGenerator = require("../../lib/dialects/sqlite/query-generator")
+  , util           = require("util");
+
+describe('QueryGenerator', function() {
+  beforeEach(function() { Helpers.sync() })
+  afterEach(function() { Helpers.drop() })
+
+  var suites = {
+    insertQuery: [
+      {
+        arguments: ['myTable', { name: 'foo' }],
+        expectation: "INSERT INTO `myTable` (`name`) VALUES ('foo');"
+      }, {
+        arguments: ['myTable', { name: "'bar'" }],
+        expectation: "INSERT INTO `myTable` (`name`) VALUES ('''bar''');"
+      }
+    ],
+
+    updateQuery: [
+      {
+        arguments: ['myTable', { name: 'foo' }, { id: 2 }],
+        expectation: "UPDATE `myTable` SET `name`='foo' WHERE `id`=2"
+      }, {
+        arguments: ['myTable', { name: "'bar'" }, { id: 2 }],
+        expectation: "UPDATE `myTable` SET `name`='''bar''' WHERE `id`=2"
+      }
+    ]
+  };
+
+  Sequelize.Utils._.each(suites, function(tests, suiteTitle) {
+    describe(suiteTitle, function() {
+      tests.forEach(function(test) {
+        var title = test.title || 'correctly returns ' + test.expectation + ' for ' + util.inspect(test.arguments)
+        it(title, function() {
+          var conditions = QueryGenerator[suiteTitle].apply(null, test.arguments)
+          expect(conditions).toEqual(test.expectation)
+        })
+      })
+    })
+  })
+});