Added check for incorrect constraints for mssql

lib/dialects/mssql/query-generator.js

@@ -322,8 +322,41 @@ module.exports = (function() {
         , key
         , key
         , attribute;
         , attribute;
 
 
-      for (key in attributes) {
+      //detect multiple cascades associated with the same id
+      var cascadeCheck = [];
+      for(key in attributes){
         attribute = attributes[key];
         attribute = attributes[key];
+        if(attribute.onDelete || attribute.onUpdate){
+          //handles self referencial keys, first it doesnt make sense, second, what?
+          if(attribute.Model && attribute.Model.tableName === attribute.references){
+            console.warn('MSSQL does not support self referencial constraints, '
+              + 'we will remove it but we recommend restructuring your query');
+            attribute.onDelete = '';
+            attribute.onUpdate = '';
+          }else{
+            cascadeCheck.push(key);
+          }
+        }
+      }
+      for(var i = 0; i < cascadeCheck.length-1; i++){
+        var casKey = cascadeCheck[i];
+        for(var j = i+1; j < cascadeCheck.length; j++){
+          var casKey2 = cascadeCheck[j];
+          if(attributes[casKey].references === attributes[casKey2].references
+            && attributes[casKey].referencesKey === attributes[casKey2].referencesKey){
+            console.warn('MSSQL does not support multiple cascade keys on the same reference, '
+              + 'we will removing them to make this work but we recommend restructuring your query.');
+            attributes[casKey].onDelete = '';
+            attributes[casKey].onUpdate = '';
+            attributes[casKey2].onDelete = '';
+            attributes[casKey2].onUpdate = '';
+          }
+        }
+      }
+
+      for(key in attributes) {
+        attribute = attributes[key];
+        //console.log(attribute);
         if(key && !attribute.field)
         if(key && !attribute.field)
           attribute.field = key;
           attribute.field = key;
         result[attribute.field || key] = SqlGenerator.attributeToSQL(attribute, options);
         result[attribute.field || key] = SqlGenerator.attributeToSQL(attribute, options);
@@ -1002,8 +1035,8 @@ module.exports = (function() {
       if (options.parent) {
       if (options.parent) {
         return;
         return;
       }
       }
-
-      return 'SET TRANSACTION ISOLATION LEVEL ' + value + ';';
+      return;
+      //return 'SET TRANSACTION ISOLATION LEVEL ' + value + ';';
     },
     },
     /**
     /**
      * Returns a query that starts a transaction.
      * Returns a query that starts a transaction.

lib/dialects/mssql/query.js

@@ -53,7 +53,9 @@ module.exports = (function() {
         });
         });
       } else{
       } else{
         var request, transCommand;
         var request, transCommand;
-        if (self.connection.lib._transaction && self.connection.uuid) {
+        if (self.connection.lib._transaction 
+          && self.connection.uuid){
+
           request = new self.connection.lib.Request(self.connection.lib._transaction);
           request = new self.connection.lib.Request(self.connection.lib._transaction);
 
 
           if (self.sql === 'COMMIT TRANSACTION;') {
           if (self.sql === 'COMMIT TRANSACTION;') {
@@ -78,7 +80,6 @@ module.exports = (function() {
         } else {
         } else {
           request = new self.connection.lib.Request(self.connection.context);
           request = new self.connection.lib.Request(self.connection.context);
         }
         }
-
         request.query(self.sql, function(err, recordset) {
         request.query(self.sql, function(err, recordset) {
           if(promise){
           if(promise){
             promise.emit('sql', self.sql, self.connection.uuid);
             promise.emit('sql', self.sql, self.connection.uuid);
@@ -143,7 +144,7 @@ module.exports = (function() {
         result = data.length;        
         result = data.length;        
       } else if (this.isBulkDeleteQuery()){
       } else if (this.isBulkDeleteQuery()){
         result = data[0].AFFECTEDROWS;
         result = data[0].AFFECTEDROWS;
-      } else if (result.dataValues){}
+      } else if (result && result.dataValues){}
       else{
       else{
         result = this.handleSelectQuery(data);
         result = this.handleSelectQuery(data);
       }
       }

lib/dialects/mssql/sql-generator.js

@@ -615,18 +615,16 @@ module.exports = {
       }
       }
 
 
       //PROBLEM WITH THIS IS MSSQL DOES NOT ALLOW MULTIPLE PER KEY
       //PROBLEM WITH THIS IS MSSQL DOES NOT ALLOW MULTIPLE PER KEY
-      if((attribute.onDelete && !attribute.onUpdate) || (!attribute.onDelete && attribute.onUpdate)){
-        if (attribute.onDelete) {
-          if(attribute.onDelete.toUpperCase() !== 'RESTRICT'){
-            template.push(attributeMap.onDelete);
-            template.push(attribute.onDelete.toUpperCase());
-          }
+      if (attribute.onDelete) {
+        if(attribute.onDelete.toUpperCase() !== 'RESTRICT'){
+          template.push(attributeMap.onDelete);
+          template.push(attribute.onDelete.toUpperCase());
         }
         }
+      }
 
 
-        if (attribute.onUpdate) {
-          template.push(attributeMap.onUpdate);
-          template.push(attribute.onUpdate.toUpperCase());
-        }
+      if (attribute.onUpdate && !attribute.onDelete) {
+        template.push(attributeMap.onUpdate);
+        template.push(attribute.onUpdate.toUpperCase());
       }
       }
     }
     }
 
 

test/include/findAll.test.js

@@ -3,7 +3,8 @@
 var chai      = require('chai')
 var chai      = require('chai')
   , Sequelize = require('../../index')
   , Sequelize = require('../../index')
   , expect    = chai.expect
   , expect    = chai.expect
-  , Support   = require(__dirname + '/../support')
+  , Support   = require(__dirname + '/../support') 
+  , dialect   = Support.getTestDialect()
   , DataTypes = require(__dirname + "/../../lib/data-types")
   , DataTypes = require(__dirname + "/../../lib/data-types")
   , datetime  = require('chai-datetime')
   , datetime  = require('chai-datetime')
   , async     = require('async')
   , async     = require('async')
@@ -17,6 +18,7 @@ var sortById = function(a, b) {
 }
 }
 
 
 describe(Support.getTestDialectTeaser("Include"), function () {
 describe(Support.getTestDialectTeaser("Include"), function () {
+
   describe('findAll', function () {
   describe('findAll', function () {
     beforeEach(function () {
     beforeEach(function () {
       this.fixtureA = function(done) {
       this.fixtureA = function(done) {