Skip to content

public / sequelize

Go to a project

不要怂，就是干，撸起袖子干！

Commit 2034852a by Sushant Committed by GitHub
Options

test: if boolean true/false are returned as string in toJSON (#8791)

1 parent 8df79fa9
Inline Side-by-side
Showing with 231 additions and 96 deletions
test/integration/instance.test.js
...@@ -1553,102 +1553,6 @@ describe(Support.getTestDialectTeaser('Instance'), () => { ...@@ -1553,102 +1553,6 @@ describe(Support.getTestDialectTeaser('Instance'), () => {
}); });
}); });
describe('toJSON', () => {
beforeEach(function() {
const self = this;
this.User = this.sequelize.define('UserWithUsernameAndAgeAndIsAdmin', {
username: DataTypes.STRING,
age: DataTypes.INTEGER,
isAdmin: DataTypes.BOOLEAN
}, { timestamps: false });
this.Project = this.sequelize.define('NiceProject', { title: DataTypes.STRING }, { timestamps: false });
this.User.hasMany(this.Project, { as: 'Projects', foreignKey: 'lovelyUserId' });
this.Project.belongsTo(this.User, { as: 'LovelyUser', foreignKey: 'lovelyUserId' });
return this.User.sync({ force: true }).then(() => {
return self.Project.sync({ force: true });
});
});
it("dont return instance that isn't defined", function() {
const self = this;
return self.Project.create({ lovelyUserId: null })
.then(project => {
return self.Project.findOne({
where: {
id: project.id
},
include: [
{ model: self.User, as: 'LovelyUser' }
]
});
})
.then(project => {
const json = project.toJSON();
expect(json.LovelyUser).to.be.equal(null);
});
});
it("dont return instances that aren't defined", function() {
const self = this;
return self.User.create({ username: 'cuss' })
.then(user => {
return self.User.findOne({
where: {
id: user.id
},
include: [
{ model: self.Project, as: 'Projects' }
]
});
})
.then(user => {
expect(user.Projects).to.be.instanceof(Array);
expect(user.Projects).to.be.length(0);
});
});
it('returns an object containing all values', function() {
const user = this.User.build({ username: 'test.user', age: 99, isAdmin: true });
expect(user.toJSON()).to.deep.equal({ username: 'test.user', age: 99, isAdmin: true, id: null });
});
it('returns a response that can be stringified', function() {
const user = this.User.build({ username: 'test.user', age: 99, isAdmin: true });
expect(JSON.stringify(user)).to.deep.equal('{"id":null,"username":"test.user","age":99,"isAdmin":true}');
});
it('returns a response that can be stringified and then parsed', function() {
const user = this.User.build({ username: 'test.user', age: 99, isAdmin: true });
expect(JSON.parse(JSON.stringify(user))).to.deep.equal({ username: 'test.user', age: 99, isAdmin: true, id: null });
});
it('includes the eagerly loaded associations', function() {
const self = this;
return this.User.create({ username: 'fnord', age: 1, isAdmin: true }).then(user => {
return self.Project.create({ title: 'fnord' }).then(project => {
return user.setProjects([project]).then(() => {
return self.User.findAll({include: [{ model: self.Project, as: 'Projects' }]}).then(users => {
const _user = users[0];
expect(_user.Projects).to.exist;
expect(JSON.parse(JSON.stringify(_user)).Projects).to.exist;
return self.Project.findAll({include: [{ model: self.User, as: 'LovelyUser' }]}).then(projects => {
const _project = projects[0];
expect(_project.LovelyUser).to.exist;
expect(JSON.parse(JSON.stringify(_project)).LovelyUser).to.exist;
});
});
});
});
});
});
});
describe('findAll', () => { describe('findAll', () => {
beforeEach(function() { beforeEach(function() {
this.ParanoidUser = this.sequelize.define('ParanoidUser', { this.ParanoidUser = this.sequelize.define('ParanoidUser', {
......
test/integration/instance/to-json.test.js 0 → 100644
'use strict';
const chai = require('chai'),
expect = chai.expect,
Support = require(__dirname + '/../support'),
DataTypes = require(__dirname + '/../../../lib/data-types');
describe(Support.getTestDialectTeaser('Instance'), () => {
describe('toJSON', () => {
beforeEach(function() {
this.User = this.sequelize.define('User', {
username: { type: DataTypes.STRING },
age: DataTypes.INTEGER,
level: { type: DataTypes.INTEGER },
isUser: {
type: DataTypes.BOOLEAN,
defaultValue: false
},
isAdmin: { type: DataTypes.BOOLEAN }
}, {
timestamps: false
});
this.Project = this.sequelize.define('NiceProject', { title: DataTypes.STRING }, { timestamps: false });
this.User.hasMany(this.Project, { as: 'Projects', foreignKey: 'lovelyUserId' });
this.Project.belongsTo(this.User, { as: 'LovelyUser', foreignKey: 'lovelyUserId' });
return this.User.sync({ force: true }).then(() => {
return this.Project.sync({ force: true });
});
});
it("dont return instance that isn't defined", function() {
const self = this;
return self.Project.create({ lovelyUserId: null })
.then(project => {
return self.Project.findOne({
where: {
id: project.id
},
include: [
{ model: self.User, as: 'LovelyUser' }
]
});
})
.then(project => {
const json = project.toJSON();
expect(json.LovelyUser).to.be.equal(null);
});
});
it("dont return instances that aren't defined", function() {
const self = this;
return self.User.create({ username: 'cuss' })
.then(user => {
return self.User.findOne({
where: {
id: user.id
},
include: [
{ model: self.Project, as: 'Projects' }
]
});
})
.then(user => {
expect(user.Projects).to.be.instanceof(Array);
expect(user.Projects).to.be.length(0);
});
});
describe('build', () => {
it('returns an object containing all values', function() {
const user = this.User.build({
username: 'Adam',
age: 22,
level: -1,
isUser: false,
isAdmin: true
});
expect(user.toJSON()).to.deep.equal({
id: null,
username: 'Adam',
age: 22,
level: -1,
isUser: false,
isAdmin: true
});
});
it('returns a response that can be stringified', function() {
const user = this.User.build({
username: 'test.user',
age: 99,
isAdmin: true,
isUser: false
});
expect(JSON.stringify(user)).to.deep.equal('{"id":null,"username":"test.user","age":99,"isAdmin":true,"isUser":false}');
});
it('returns a response that can be stringified and then parsed', function() {
const user = this.User.build({ username: 'test.user', age: 99, isAdmin: true });
expect(JSON.parse(JSON.stringify(user))).to.deep.equal({ username: 'test.user', age: 99, isAdmin: true, isUser: false, id: null });
});
});
describe('create', () => {
it('returns an object containing all values', function() {
return this.User.create({
username: 'Adam',
age: 22,
level: -1,
isUser: false,
isAdmin: true
}).then(user => {
expect(user.toJSON()).to.deep.equal({
id: user.get('id'),
username: 'Adam',
age: 22,
isUser: false,
isAdmin: true,
level: -1
});
});
});
it('returns a response that can be stringified', function() {
return this.User.create({
username: 'test.user',
age: 99,
isAdmin: true,
isUser: false,
level: null
}).then(user => {
expect(JSON.stringify(user)).to.deep.equal(`{"id":${user.get('id')},"username":"test.user","age":99,"isAdmin":true,"isUser":false,"level":null}`);
});
});
it('returns a response that can be stringified and then parsed', function() {
return this.User.create({
username: 'test.user',
age: 99,
isAdmin: true,
level: null
}).then(user => {
expect(JSON.parse(JSON.stringify(user))).to.deep.equal({
age: 99,
id: user.get('id'),
isAdmin: true,
isUser: false,
level: null,
username: 'test.user'
});
});
});
});
describe('find', () => {
it('returns an object containing all values', function() {
return this.User.create({
username: 'Adam',
age: 22,
level: -1,
isUser: false,
isAdmin: true
}).then(user => this.User.findById(user.get('id'))).then(user => {
expect(user.toJSON()).to.deep.equal({
id: user.get('id'),
username: 'Adam',
age: 22,
level: -1,
isUser: false,
isAdmin: true
});
});
});
it('returns a response that can be stringified', function() {
return this.User.create({
username: 'test.user',
age: 99,
isAdmin: true,
isUser: false
}).then(user => this.User.findById(user.get('id'))).then(user => {
expect(JSON.stringify(user)).to.deep.equal(`{"id":${user.get('id')},"username":"test.user","age":99,"level":null,"isUser":false,"isAdmin":true}`);
});
});
it('returns a response that can be stringified and then parsed', function() {
return this.User.create({
username: 'test.user',
age: 99,
isAdmin: true
}).then(user => this.User.findById(user.get('id'))).then(user => {
expect(JSON.parse(JSON.stringify(user))).to.deep.equal({
id: user.get('id'),
username: 'test.user',
age: 99,
isAdmin: true,
isUser: false,
level: null
});
});
});
});
it('includes the eagerly loaded associations', function() {
const self = this;
return this.User.create({ username: 'fnord', age: 1, isAdmin: true }).then(user => {
return self.Project.create({ title: 'fnord' }).then(project => {
return user.setProjects([project]).then(() => {
return self.User.findAll({include: [{ model: self.Project, as: 'Projects' }]}).then(users => {
const _user = users[0];
expect(_user.Projects).to.exist;
expect(JSON.parse(JSON.stringify(_user)).Projects).to.exist;
return self.Project.findAll({include: [{ model: self.User, as: 'LovelyUser' }]}).then(projects => {
const _project = projects[0];
expect(_project.LovelyUser).to.exist;
expect(JSON.parse(JSON.stringify(_project)).LovelyUser).to.exist;
});
});
});
});
});
});
});
});
Markdown is supported
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!