use strict mode for all library scripts

Matt Broadstone
Commit 29a79549 authored May 21, 2014 by Matt Broadstone
Showing with 103 additions and 19 deletions
lib/associations/belongs-to.js
lib/associations/has-many-double-linked.js
lib/associations/has-many-single-linked.js
lib/associations/has-many.js
lib/associations/has-one.js
lib/associations/helpers.js
lib/associations/mixin.js
lib/data-types.js
lib/dialects/abstract/connector-manager.js
lib/dialects/abstract/index.js
lib/dialects/abstract/query-generator.js
lib/dialects/abstract/query.js
lib/dialects/mariadb/connector-manager.js
lib/dialects/mariadb/index.js
lib/dialects/mariadb/query-generator.js
lib/dialects/mariadb/query.js
lib/dialects/mysql/connector-manager.js
lib/dialects/mysql/index.js
lib/dialects/mysql/query-generator.js
lib/dialects/mysql/query.js
--- a/lib/associations/belongs-to.js
+++ b/lib/associations/belongs-to.js
+"use strict";
 var Utils       = require("./../utils")
  , Helpers     = require('./helpers')
  , Transaction = require('../transaction')

--- a/lib/associations/has-many-double-linked.js
+++ b/lib/associations/has-many-double-linked.js
+"use strict";
 var Utils       = require('./../utils')
  , Transaction = require('./../transaction')

--- a/lib/associations/has-many-single-linked.js
+++ b/lib/associations/has-many-single-linked.js
+"use strict";
 var Utils       = require('./../utils')
  , Transaction = require('./../transaction')

--- a/lib/associations/has-many.js
+++ b/lib/associations/has-many.js
+"use strict";
 var Utils      = require("./../utils")
  , Helpers    = require('./helpers')
  , _          = require('lodash')

--- a/lib/associations/has-one.js
+++ b/lib/associations/has-one.js
+"use strict";
 var Utils       = require("./../utils")
  , Helpers     = require("./helpers")
  , Transaction = require("../transaction")

--- a/lib/associations/helpers.js
+++ b/lib/associations/helpers.js
+"use strict";
 var Utils = require("./../utils")
 module.exports = {

--- a/lib/associations/mixin.js
+++ b/lib/associations/mixin.js
+"use strict";
 var Utils     = require("./../utils")
  , HasOne    = require('./has-one')
  , HasMany   = require("./has-many")

--- a/lib/data-types.js
+++ b/lib/data-types.js
+"use strict";
 var STRING = function(length, binary) {
  if (this instanceof STRING) {
    this._binary = !!binary

--- a/lib/dialects/abstract/connector-manager.js
+++ b/lib/dialects/abstract/connector-manager.js
+"use strict";
 module.exports = (function(){
  var ConnectorManager = function(sequelize, config) {
    throw new Error('Define the constructor!')

--- a/lib/dialects/abstract/index.js
+++ b/lib/dialects/abstract/index.js
+"use strict";
 var AbstractDialect = function() {
 }

--- a/lib/dialects/abstract/query-generator.js
+++ b/lib/dialects/abstract/query-generator.js
+"use strict";
 var Utils = require("../../utils")
  , SqlString = require("../../sql-string")
  , Model = require("../../model")

--- a/lib/dialects/abstract/query.js
+++ b/lib/dialects/abstract/query.js
+"use strict";
 var Utils              = require('../../utils')
  , CustomEventEmitter = require("../../emitters/custom-event-emitter")
  , Promise            = require("../../promise")

--- a/lib/dialects/mariadb/connector-manager.js
+++ b/lib/dialects/mariadb/connector-manager.js
+"use strict";
 var mariadb
  , Pooling = require('generic-pool')
  , Query   = require("./query")

--- a/lib/dialects/mariadb/index.js
+++ b/lib/dialects/mariadb/index.js
+"use strict";
 var _ = require('lodash')
  , MySQL = require('../mysql')

--- a/lib/dialects/mariadb/query-generator.js
+++ b/lib/dialects/mariadb/query-generator.js
+"use strict";
 var Utils     = require("../../utils")
 module.exports = (function() {

--- a/lib/dialects/mariadb/query.js
+++ b/lib/dialects/mariadb/query.js
+"use strict";
 var Utils         = require("../../utils")
  , AbstractQuery = require('../abstract/query')

--- a/lib/dialects/mysql/connector-manager.js
+++ b/lib/dialects/mysql/connector-manager.js
+"use strict";
 var mysql
  , Pooling = require('generic-pool')
  , Query   = require("./query")

--- a/lib/dialects/mysql/index.js
+++ b/lib/dialects/mysql/index.js
+"use strict";
 var _ = require('lodash')
  , Abstract = require('../abstract')

--- a/lib/dialects/mysql/query-generator.js
+++ b/lib/dialects/mysql/query-generator.js
+"use strict";
 var Utils     = require("../../utils")
  , DataTypes = require("../../data-types")
  , util      = require("util")

--- a/lib/dialects/mysql/query.js
+++ b/lib/dialects/mysql/query.js
+"use strict";
 var Utils         = require("../../utils")
  , AbstractQuery = require('../abstract/query')
  , uuid          = require('node-uuid')

--- a/lib/dialects/postgres/connector-manager.js
+++ b/lib/dialects/postgres/connector-manager.js
+"use strict";
 var Query                = require("./query")
  , Utils                = require("../../utils")

--- a/lib/dialects/postgres/hstore.js
+++ b/lib/dialects/postgres/hstore.js
+"use strict";
 module.exports = {
  stringifyPart: function(part) {
    switch(typeof part) {
@@ -41,7 +43,7 @@ module.exports = {
      return object;
    }
-    const rx = /\"((?:\\\"|[^"])*)\"\s*\=\>\s*((?:true|false|NULL|\d+|\d+\.\d+|\"((?:\\\"|[^"])*)\"))/g
+    var rx = /\"((?:\\\"|[^"])*)\"\s*\=\>\s*((?:true|false|NULL|\d+|\d+\.\d+|\"((?:\\\"|[^"])*)\"))/g
    string = string || '';

--- a/lib/dialects/postgres/index.js
+++ b/lib/dialects/postgres/index.js
+"use strict";
 var _ = require('lodash')
  , Abstract = require('../abstract')

--- a/lib/dialects/postgres/query-generator.js
+++ b/lib/dialects/postgres/query-generator.js
+"use strict";
 var Utils       = require("../../utils")
  , hstore      = require('./hstore')
  , util        = require("util")

--- a/lib/dialects/postgres/query.js
+++ b/lib/dialects/postgres/query.js
+"use strict";
 var Utils         = require("../../utils")
  , AbstractQuery = require('../abstract/query')
  , DataTypes     = require('../../data-types')

--- a/lib/dialects/sqlite/connector-manager.js
+++ b/lib/dialects/sqlite/connector-manager.js
+"use strict";
 var sqlite3
  , Utils   = require("../../utils")
  , Query   = require("./query")

--- a/lib/dialects/sqlite/index.js
+++ b/lib/dialects/sqlite/index.js
+"use strict";
 var _ = require('lodash')
  , Abstract = require('../abstract')

--- a/lib/dialects/sqlite/query-generator.js
+++ b/lib/dialects/sqlite/query-generator.js
+"use strict";
 var Utils       = require("../../utils")
  , DataTypes   = require("../../data-types")
  , SqlString   = require("../../sql-string")

--- a/lib/dialects/sqlite/query-interface.js
+++ b/lib/dialects/sqlite/query-interface.js
+"use strict";
 var Utils = require("../../utils")
 /**

--- a/lib/dialects/sqlite/query.js
+++ b/lib/dialects/sqlite/query.js
+"use strict";
 var Utils         = require("../../utils")
  , AbstractQuery = require('../abstract/query')
  , QueryTypes    = require('../../query-types')

--- a/lib/emitters/custom-event-emitter.js
+++ b/lib/emitters/custom-event-emitter.js
+"use strict";
 var util           = require("util")
  , EventEmitter   = require("events").EventEmitter
  , Promise        = require("../promise")

--- a/lib/errors.js
+++ b/lib/errors.js
+"use strict";
 /**
 * @fileOverview The Error Objects produced by Sequelize.
 */

--- a/lib/hooks.js
+++ b/lib/hooks.js
+"use strict";
 var Utils = require("./utils")
  , Promise = require("./promise")

--- a/lib/instance-validator.js
+++ b/lib/instance-validator.js
+"use strict";
 var Validator = require("validator")
  , Utils     = require("./utils")
  , sequelizeError = require("./errors")

--- a/lib/instance.js
+++ b/lib/instance.js
+"use strict";
 var Utils             = require("./utils")
  , Mixin             = require("./associations/mixin")
  , InstanceValidator = require("./instance-validator")

--- a/lib/migration.js
+++ b/lib/migration.js
+"use strict";
 var moment         = require("moment")
  , path           = require("path")
  , Utils          = require("./utils")

--- a/lib/migrator.js
+++ b/lib/migrator.js
-const fs     = require("fs")
+"use strict";
-    , moment = require("moment")
+var fs     = require("fs")
+  , moment = require("moment")
 var Utils          = require(__dirname + "/utils")
  , Migration      = require(__dirname + "/migration")

--- a/lib/model-manager.js
+++ b/lib/model-manager.js
+"use strict";
 var Toposort   = require('toposort-class')
  , _          = require('lodash')

--- a/lib/model.js
+++ b/lib/model.js
@@ -127,15 +127,6 @@ module.exports = (function() {
    this.scopeObj          = {}
  }
-  /**
-   * A reference to the sequelize instance
-   * @property sequelize
-   * @return {Sequelize}
-   */
-  Object.defineProperty(Model.prototype, 'sequelize', {
-    get: function() { return this.modelManager.sequelize }
-  })
  Object.defineProperty(Model.prototype, 'QueryInterface', {
    get: function() { return this.modelManager.sequelize.getQueryInterface() }
  })

--- a/lib/model/attribute.js
+++ b/lib/model/attribute.js
+"use strict";
 module.exports = (function () {
 	var Attribute = function(options) {
 		if (options.type === undefined) options = {type: options};

--- a/lib/promise.js
+++ b/lib/promise.js
+"use strict";
 var Promise
  , EventEmitter    = require("events").EventEmitter
  , proxyEventKeys  = ['success', 'error', 'sql']

--- a/lib/query-chainer.js
+++ b/lib/query-chainer.js
+"use strict";
 var Utils = require(__dirname + "/utils")
 module.exports = (function() {

--- a/lib/query-interface.js
+++ b/lib/query-interface.js
+"use strict";
 var Utils                = require(__dirname + '/utils')
  , DataTypes            = require(__dirname + '/data-types')
  , SQLiteQueryInterface = require(__dirname + '/dialects/sqlite/query-interface')

--- a/lib/query-types.js
+++ b/lib/query-types.js
+"use strict";
 module.exports = {
  SELECT: 'SELECT',
  BULKUPDATE: 'BULKUPDATE',

--- a/lib/sequelize.js
+++ b/lib/sequelize.js
+"use strict";
 var url                = require("url")
  , Path               = require("path")
  , Utils              = require("./utils")
@@ -97,7 +99,6 @@ module.exports = (function() {
        database = urlParts.pathname.replace(/^\//,  '')
      }
-      dialect = urlParts.protocol
      options.dialect = urlParts.protocol.replace(/:$/, '')
      options.host = urlParts.hostname

--- a/lib/sql-string.js
+++ b/lib/sql-string.js
+"use strict";
 var moment = require("moment")
  , isArrayBufferView
  , SqlString = exports;

--- a/lib/transaction-manager.js
+++ b/lib/transaction-manager.js
+"use strict";
 var Utils = require('./utils')
 var TransactionManager = module.exports = function(sequelize) {

--- a/lib/transaction.js
+++ b/lib/transaction.js
+"use strict";
 var Utils = require('./utils')
  , util  = require('util')

--- a/lib/utils.js
+++ b/lib/utils.js
+"use strict";
 var util               = require("util")
  , DataTypes          = require("./data-types")
  , SqlString          = require("./sql-string")
@@ -471,7 +473,7 @@ var Utils = module.exports = {
    var orig = Error.prepareStackTrace;
    Error.prepareStackTrace = function(_, stack){ return stack; };
    var err = new Error();
-    Error.captureStackTrace(err, arguments.callee);
+    Error.captureStackTrace(err, stack);
    var stack = err.stack;
    Error.prepareStackTrace = orig;
    return stack;

--- a/lib/utils/parameter-validator.js
+++ b/lib/utils/parameter-validator.js
+"use strict";
 var cJSON = require('circular-json')
  , _ = require('lodash') // Don't require Utils here, as it creates a circular dependency

--- a/test/dao-factory.test.js
+++ b/test/dao-factory.test.js
@@ -1989,13 +1989,9 @@ describe(Support.getTestDialectTeaser("DAOFactory"), function () {
    })
    it('should not fail with an include', function(done) {
-      var tableName = ''
-        , ident = this.sequelize.queryInterface.QueryGenerator.quoteIdentifier
-        , escape = this.sequelize.queryInterface.QueryGenerator.escape
      this.User.findAll({
        where: [
-          this.sequelize.queryInterface.QueryGenerator.quoteIdentifiers('Projects.title') + ' = ' + escape('republic')
+          this.sequelize.queryInterface.QueryGenerator.quoteIdentifiers('Projects.title') + ' = ' + this.sequelize.queryInterface.QueryGenerator.escape('republic')
        ],
        include: [
          {model: this.Project}