fix(subquery): check required association exists (#7905)

lib/dialects/abstract/query-generator.js

@@ -1331,7 +1331,8 @@ const QueryGenerator = {
               include.where || {}
             ]
           },
-          limit: 1
+          limit: 1,
+          tableAs: include.as
         }, include.model);
 
         const subQueryWhere = this.sequelize.asIs([

lib/dialects/mssql/query-generator.js

@@ -848,7 +848,7 @@ const QueryGenerator = {
     if (options.limit || options.offset) {
       if (!options.order || options.include && !orders.subQueryOrder.length) {
         fragment += options.order && !isSubQuery ? ', ' : ' ORDER BY ';
-        fragment += this.quoteTable(model.name) + '.' + this.quoteIdentifier(model.primaryKeyField);
+        fragment += this.quoteTable(options.tableAs || model.name) + '.' + this.quoteIdentifier(model.primaryKeyField);
       }
 
       if (options.offset || options.limit) {

test/unit/sql/select.test.js

@@ -372,6 +372,49 @@ suite(Support.getTestDialectTeaser('SQL'), () => {
         default: 'SELECT [User].[name], [User].[age], [Posts].[id] AS [Posts.id], [Posts].[title] AS [Posts.title] FROM [User] AS [User] LEFT OUTER JOIN [Post] AS [Posts] ON [User].[id] = [Posts].[user_id];'
       });
     });
+
+    it('include (subQuery alias)', () => {
+      const User = Support.sequelize.define('User', {
+        name: DataTypes.STRING,
+        age: DataTypes.INTEGER
+      },
+      {
+        freezeTableName: true
+      });
+      const Post = Support.sequelize.define('Post', {
+        title: DataTypes.STRING
+      },
+      {
+        freezeTableName: true
+      });
+
+      User.Posts = User.hasMany(Post, {foreignKey: 'user_id', as: 'postaliasname'});
+
+      expectsql(sql.selectQuery('User', {
+        table: User.getTableName(),
+        model: User,
+        attributes: ['name', 'age'],
+        include: Model._validateIncludedElements({
+          include: [{
+            attributes: ['title'],
+            association: User.Posts,
+            subQuery: true,
+            required: true
+          }],
+          as: 'User'
+        }).include,
+        subQuery: true
+      }, User), {
+        default: 'SELECT [User].*, [postaliasname].[id] AS [postaliasname.id], [postaliasname].[title] AS [postaliasname.title] FROM ' +
+          '(SELECT [User].[name], [User].[age], [User].[id] AS [id] FROM [User] AS [User] ' +
+          'WHERE ( SELECT [user_id] FROM [Post] AS [postaliasname] WHERE ([postaliasname].[user_id] = [User].[id]) LIMIT 1 ) IS NOT NULL) AS [User] ' +
+          'INNER JOIN [Post] AS [postaliasname] ON [User].[id] = [postaliasname].[user_id];',
+        mssql: 'SELECT [User].*, [postaliasname].[id] AS [postaliasname.id], [postaliasname].[title] AS [postaliasname.title] FROM ' +
+          '(SELECT [User].[name], [User].[age], [User].[id] AS [id] FROM [User] AS [User] ' +
+          'WHERE ( SELECT [user_id] FROM [Post] AS [postaliasname] WHERE ([postaliasname].[user_id] = [User].[id]) ORDER BY [postaliasname].[id] OFFSET 0 ROWS FETCH NEXT 1 ROWS ONLY ) IS NOT NULL) AS [User] ' +
+          'INNER JOIN [Post] AS [postaliasname] ON [User].[id] = [postaliasname].[user_id];'
+      });
+    });
   });
 
   suite('queryIdentifiersFalse', () => {