Force quoting of savepoint identifiers in the postgres adapter.

lib/dialects/abstract/query-generator.js

@@ -1697,7 +1697,8 @@ var QueryGenerator = {
    */
    */
   startTransactionQuery: function(transaction) {
   startTransactionQuery: function(transaction) {
     if (transaction.parent) {
     if (transaction.parent) {
-      return 'SAVEPOINT ' + this.quoteIdentifier(transaction.name) + ';';
+      // force quoting of savepoint identifiers for postgres
+      return 'SAVEPOINT ' + this.quoteIdentifier(transaction.name, true) + ';';
     }
     }
 
 
     return 'START TRANSACTION;';
     return 'START TRANSACTION;';
@@ -1739,7 +1740,8 @@ var QueryGenerator = {
    */
    */
   rollbackTransactionQuery: function(transaction) {
   rollbackTransactionQuery: function(transaction) {
     if (transaction.parent) {
     if (transaction.parent) {
-      return 'ROLLBACK TO SAVEPOINT ' + this.quoteIdentifier(transaction.name) + ';';
+      // force quoting of savepoint identifiers for postgres
+      return 'ROLLBACK TO SAVEPOINT ' + this.quoteIdentifier(transaction.name, true) + ';';
     }
     }
 
 
     return 'ROLLBACK;';
     return 'ROLLBACK;';

test/unit/dialects/postgres/query-generator.test.js

@@ -862,6 +862,42 @@ if (dialect.match(/^postgres/)) {
           expectation: 'DROP INDEX IF EXISTS mySchema.user_foo_bar',
           expectation: 'DROP INDEX IF EXISTS mySchema.user_foo_bar',
           context: {options: {quoteIdentifiers: false}}
           context: {options: {quoteIdentifiers: false}}
         }
         }
+      ],
+
+      startTransactionQuery: [
+        {
+          arguments: [{}],
+          expectation: 'START TRANSACTION;',
+          context: {options: {quoteIdentifiers: false}}
+        },
+        {
+          arguments: [{parent: 'MockTransaction', name: 'transaction-uid'}],
+          expectation: 'SAVEPOINT \"transaction-uid\";',
+          context: {options: {quoteIdentifiers: false}}
+        },
+        {
+          arguments: [{parent: 'MockTransaction', name: 'transaction-uid'}],
+          expectation: 'SAVEPOINT \"transaction-uid\";',
+          context: {options: {quoteIdentifiers: true}}
+        }
+      ],
+
+      rollbackTransactionQuery: [
+        {
+          arguments: [{}],
+          expectation: 'ROLLBACK;',
+          context: {options: {quoteIdentifiers: false}}
+        },
+        {
+          arguments: [{parent: 'MockTransaction', name: 'transaction-uid'}],
+          expectation: 'ROLLBACK TO SAVEPOINT \"transaction-uid\";',
+          context: {options: {quoteIdentifiers: false}}
+        },
+        {
+          arguments: [{parent: 'MockTransaction', name: 'transaction-uid'}],
+          expectation: 'ROLLBACK TO SAVEPOINT \"transaction-uid\";',
+          context: {options: {quoteIdentifiers: true}}
+        }
       ]
       ]
     };
     };