minor refactoring

lib/associations/has-many-double-linked.js

@@ -11,6 +11,7 @@ module.exports = (function() {
 
 
     var customEventEmitter = new Utils.CustomEventEmitter(function() {
     var customEventEmitter = new Utils.CustomEventEmitter(function() {
       var where = {}
       var where = {}
+
       //fully qualify
       //fully qualify
       where[self.__factory.connectorDAO.tableName+"."+self.__factory.identifier] = self.instance.id
       where[self.__factory.connectorDAO.tableName+"."+self.__factory.identifier] = self.instance.id
 
 
@@ -60,13 +61,14 @@ module.exports = (function() {
   var destroyObsoleteAssociations = function(oldAssociations, newAssociations) {
   var destroyObsoleteAssociations = function(oldAssociations, newAssociations) {
     var self = this
     var self = this
 
 
-    var emitter = new Utils.CustomEventEmitter(function() {
-      var chainer = new Utils.QueryChainer
+    return new Utils.CustomEventEmitter(function(emitter) {
+      var chainer = new Utils.QueryChainer()
       var foreignIdentifier = self.__factory.target.associations[self.__factory.associationAccessor].identifier
       var foreignIdentifier = self.__factory.target.associations[self.__factory.associationAccessor].identifier
       var obsoleteAssociations = oldAssociations.filter(function(obj) { return !obj.equalsOneOf(newAssociations) })
       var obsoleteAssociations = oldAssociations.filter(function(obj) { return !obj.equalsOneOf(newAssociations) })
 
 
-      if(obsoleteAssociations.length == 0)
+      if(obsoleteAssociations.length == 0) {
         return emitter.emit('success', null)
         return emitter.emit('success', null)
+      }
 
 
       obsoleteAssociations.forEach(function(associatedObject) {
       obsoleteAssociations.forEach(function(associatedObject) {
         var where       = {}
         var where       = {}
@@ -89,8 +91,7 @@ module.exports = (function() {
           }
           }
         })
         })
       })
       })
-    })
-    return emitter.run()
+    }).run()
   }
   }
 
 
   return HasManyDoubleLinked
   return HasManyDoubleLinked