[ci skip] Change poly assoc docs a bit. Closes #3734

docs/docs/associations.md

@@ -211,39 +211,43 @@ this.Comment = this.sequelize.define('comment', {
 
 
 this.Post.hasMany(this.Comment, {
 this.Post.hasMany(this.Comment, {
   foreignKey: 'commentable_id',
   foreignKey: 'commentable_id',
+  constraints: false,
   scope: {
   scope: {
     commentable: 'post'
     commentable: 'post'
   }
   }
 });
 });
 this.Comment.belongsTo(this.Post, {
 this.Comment.belongsTo(this.Post, {
   foreignKey: 'commentable_id',
   foreignKey: 'commentable_id',
+  constraints: false,
   as: 'post'
   as: 'post'
 });
 });
 
 
 this.Image.hasMany(this.Comment, {
 this.Image.hasMany(this.Comment, {
   foreignKey: 'commentable_id',
   foreignKey: 'commentable_id',
+  constraints: false,
   scope: {
   scope: {
     commentable: 'image'
     commentable: 'image'
   }
   }
 });
 });
 this.Comment.belongsTo(this.Image, {
 this.Comment.belongsTo(this.Image, {
   foreignKey: 'commentable_id',
   foreignKey: 'commentable_id',
+  constraints: false,
   as: 'image'
   as: 'image'
 });
 });
 ```
 ```
 
 
-Note that the Image -> Comment and Post -> Comment relations define a scope, `commentable: 'image'` and `commentable: 'post'` respectively. This scope is automatically applied when using the association functions:
+`constraints: false,` disables references constraints - since the `commentable_id` column references several tables, we cannot add a `REFERENCES` constraint to it. Note that the Image -> Comment and Post -> Comment relations define a scope, `commentable: 'image'` and `commentable: 'post'` respectively. This scope is automatically applied when using the association functions:
 
 
 ```js
 ```js
-Image.getComments()
+image.getComments()
 SELECT * FROM comments WHERE commentable_id = 42 AND commentable = 'image';
 SELECT * FROM comments WHERE commentable_id = 42 AND commentable = 'image';
 
 
-Image.createComment({
+image.createComment({
   title: 'Awesome!'
   title: 'Awesome!'
 })
 })
 INSERT INTO comments (title, commentable_id, commentable) VALUES ('Awesome!', 'image', 42);
 INSERT INTO comments (title, commentable_id, commentable) VALUES ('Awesome!', 'image', 42);
 
 
-Image.addComment(comment);
+image.addComment(comment);
 UPDATE comments SET commentable_id = 42, commentable = 'image'
 UPDATE comments SET commentable_id = 42, commentable = 'image'
 ```
 ```