Merge pull request #1014 from leogdion + Added tests

lib/dialects/abstract/query-generator.js

@@ -687,7 +687,7 @@ module.exports = (function() {
 
         if (Array.isArray(value)) {
           result.push(this.arrayValue(value, key, _key, dao))
-        } else if ((value) && (typeof value == 'object') && !(value instanceof Date)) {
+        } else if ((value) && (typeof value == 'object') && !(value instanceof Date) && !Buffer.isBuffer(value)) {
           if (!!value.join) {
             //using as sentinel for join column => value
             _value = this.quoteIdentifiers(value.join)

test/mysql/query-generator.test.js

@@ -268,6 +268,11 @@ if (Support.dialectIsMySQL()) {
           arguments: ['myTable', {where: null}],
           expectation: "SELECT * FROM `myTable` WHERE 1=1;",
           context: QueryGenerator
+        }, {
+          title: 'buffer as where argument',
+          arguments: ['myTable', {where: { field: new Buffer("Sequelize")}}],
+          expectation: "SELECT * FROM `myTable` WHERE `myTable`.`field`=X'53657175656c697a65';",
+          context: QueryGenerator
         }
       ],
 

test/postgres/query-generator.test.js

@@ -333,6 +333,11 @@ if (dialect.match(/^postgres/)) {
         }, {
           arguments: ['mySchema.myTable', {where: {name: "foo';DROP TABLE mySchema.myTable;"}}],
           expectation: "SELECT * FROM \"mySchema\".\"myTable\" WHERE \"mySchema\".\"myTable\".\"name\"='foo'';DROP TABLE mySchema.myTable;';"
+        }, {
+          title: 'buffer as where argument',
+          arguments: ['myTable', {where: { field: new Buffer("Sequelize")}}],
+          expectation: "SELECT * FROM \"myTable\" WHERE \"myTable\".\"field\"=E'\\\\x53657175656c697a65';",
+          context: QueryGenerator
         },
 
         // Variants when quoteIdentifiers is false

test/sqlite/query-generator.test.js

@@ -255,6 +255,11 @@ if (dialect === 'sqlite') {
           arguments: ['myTable', {where: null}],
           expectation: "SELECT * FROM `myTable` WHERE 1=1;",
           context: QueryGenerator
+        }, {
+          title: 'buffer as where argument',
+          arguments: ['myTable', {where: { field: new Buffer("Sequelize")}}],
+          expectation: "SELECT * FROM `myTable` WHERE `myTable`.`field`=X'53657175656c697a65';",
+          context: QueryGenerator
         }
       ],