Merge pull request #3567 from BridgeAR/fix-error-msg

Foreign languages used in the db might crash the app

lib/dialects/mysql/query.js

@@ -112,7 +112,7 @@ module.exports = (function() {
       case 1062:
       case 1062:
         match = err.message.match(/Duplicate entry '(.*)' for key '?((.|\s)*?)'?$/);
         match = err.message.match(/Duplicate entry '(.*)' for key '?((.|\s)*?)'?$/);
 
 
-        var values = match[1].split('-')
+        var values = match ? match[1].split('-') : undefined
           , fields = {}
           , fields = {}
           , message = 'Validation error'
           , message = 'Validation error'
           , uniqueKey = this.callee && this.callee.__options.uniqueKeys[match[2]];
           , uniqueKey = this.callee && this.callee.__options.uniqueKeys[match[2]];
@@ -142,7 +142,7 @@ module.exports = (function() {
 
 
         return new sequelizeErrors.ForeignKeyConstraintError({
         return new sequelizeErrors.ForeignKeyConstraintError({
           fields: null,
           fields: null,
-          index: match[3],
+          index: match ? match[3] : undefined,
           parent: err
           parent: err
         });
         });
 
 
@@ -151,7 +151,7 @@ module.exports = (function() {
 
 
         return new sequelizeErrors.ForeignKeyConstraintError({
         return new sequelizeErrors.ForeignKeyConstraintError({
           fields: null,
           fields: null,
-          index: match[1],
+          index: match ? match[1] : undefined,
           parent: err
           parent: err
         });
         });
 
 

lib/dialects/postgres/query.js

@@ -354,8 +354,10 @@ module.exports = (function() {
 
 
     switch (code) {
     switch (code) {
       case '23503':
       case '23503':
-        index = errMessage.match(/violates foreign key constraint \"(.+?)\"/)[1];
-        table = errMessage.match(/on table \"(.+?)\"/)[1];
+        index = errMessage.match(/violates foreign key constraint \"(.+?)\"/);
+        index = index ? index[1] : undefined;
+        table = errMessage.match(/on table \"(.+?)\"/);
+        table = table ? table[1] : undefined;
 
 
         return new sequelizeErrors.ForeignKeyConstraintError({
         return new sequelizeErrors.ForeignKeyConstraintError({
           fields: null,
           fields: null,
@@ -404,7 +406,9 @@ module.exports = (function() {
       case '23P01':
       case '23P01':
         match = errDetail.match(/Key \((.*?)\)=\((.*?)\)/);
         match = errDetail.match(/Key \((.*?)\)=\((.*?)\)/);
 
 
+        if (match) {
           fields = Utils._.zipObject(match[1].split(', '), match[2].split(', '));
           fields = Utils._.zipObject(match[1].split(', '), match[2].split(', '));
+        }
         message = 'Exclusion constraint error';
         message = 'Exclusion constraint error';
 
 
         return new sequelizeErrors.ExclusionConstraintError({
         return new sequelizeErrors.ExclusionConstraintError({