Comments on comments on comments

lib/dialects/abstract/query-generator.js

@@ -462,6 +462,8 @@ module.exports = (function() {
     */
     */
 
 
     selectQuery: function(tableName, options, factory) {
     selectQuery: function(tableName, options, factory) {
+      // Enter and change at your own peril -- Mick Hansen
+
       options       = options || {}
       options       = options || {}
 
 
       var table               = null
       var table               = null
@@ -583,15 +585,21 @@ module.exports = (function() {
               mainAttributes = mainAttributes.concat(throughAttributes)
               mainAttributes = mainAttributes.concat(throughAttributes)
             }
             }
 
 
+            // Filter statement for left side of through
+            // Used by both join and subquery where
             sourceJoinOn = self.quoteIdentifier(tableSource) + "." + self.quoteIdentifier(attrSource) + " = "
             sourceJoinOn = self.quoteIdentifier(tableSource) + "." + self.quoteIdentifier(attrSource) + " = "
               sourceJoinOn += self.quoteIdentifier(throughAs) + "." + self.quoteIdentifier(identSource)
               sourceJoinOn += self.quoteIdentifier(throughAs) + "." + self.quoteIdentifier(identSource)
 
 
+            // Filter statement for right side of through
+            // Used by both join and subquery where
             targetJoinOn = self.quoteIdentifier(tableTarget) + "." + self.quoteIdentifier(attrTarget) + " = "
             targetJoinOn = self.quoteIdentifier(tableTarget) + "." + self.quoteIdentifier(attrTarget) + " = "
               targetJoinOn += self.quoteIdentifier(throughAs) + "." + self.quoteIdentifier(identTarget)
               targetJoinOn += self.quoteIdentifier(throughAs) + "." + self.quoteIdentifier(identTarget)
 
 
+            // Generate join SQL for left side of through
             joinQueryItem += joinType + self.quoteIdentifier(throughTable) + " AS " + self.quoteIdentifier(throughAs) + " ON "
             joinQueryItem += joinType + self.quoteIdentifier(throughTable) + " AS " + self.quoteIdentifier(throughAs) + " ON "
               joinQueryItem += sourceJoinOn
               joinQueryItem += sourceJoinOn
 
 
+            // Generate join SQL for right side of through
             joinQueryItem += joinType + self.quoteIdentifier(table) + " AS " + self.quoteIdentifier(as) + " ON "
             joinQueryItem += joinType + self.quoteIdentifier(table) + " AS " + self.quoteIdentifier(as) + " ON "
               joinQueryItem += targetJoinOn
               joinQueryItem += targetJoinOn
 
 
@@ -621,9 +629,12 @@ module.exports = (function() {
               , attrRight       = association.identifier
               , attrRight       = association.identifier
               , where
               , where
 
 
+            // Filter statement
+            // Used by both join and subquery where
             where = self.quoteIdentifier(tableLeft) + "." + self.quoteIdentifier(attrLeft) + " = "
             where = self.quoteIdentifier(tableLeft) + "." + self.quoteIdentifier(attrLeft) + " = "
             where += self.quoteIdentifier(tableRight) + "." + self.quoteIdentifier(attrRight)
             where += self.quoteIdentifier(tableRight) + "." + self.quoteIdentifier(attrRight)
 
 
+            // Generate join SQL
             joinQueryItem += joinType + self.quoteIdentifier(table) + " AS " + self.quoteIdentifier(as) + " ON "
             joinQueryItem += joinType + self.quoteIdentifier(table) + " AS " + self.quoteIdentifier(as) + " ON "
               joinQueryItem += where
               joinQueryItem += where