Fixing stack trace capturing and switching back to util.inerhits

lib/errors.js

@@ -4,6 +4,7 @@
  * @fileOverview The Error Objects produced by Sequelize.
  * @fileOverview The Error Objects produced by Sequelize.
  */
  */
 
 
+var util = require('util');
 var error = module.exports = {};
 var error = module.exports = {};
 
 
 /**
 /**
@@ -15,14 +16,10 @@ error.BaseError = function() {
   var tmp = Error.apply(this, arguments);
   var tmp = Error.apply(this, arguments);
   tmp.name = this.name = 'SequelizeBaseError';
   tmp.name = this.name = 'SequelizeBaseError';
 
 
-  this.stack = tmp.stack;
+  Error.captureStackTrace && Error.captureStackTrace(this, this.constructor);
   this.message = tmp.message;
   this.message = tmp.message;
-
-  return this;
 };
 };
-error.BaseError.prototype = Object.create(Error.prototype, {
-  constructor: { value: error.BaseError }
-});
+util.inherits(error.BaseError, Error);
 
 
 
 
 /**
 /**
@@ -34,12 +31,8 @@ error.ValidationError = function(message, errors) {
   error.BaseError.apply(this, arguments);
   error.BaseError.apply(this, arguments);
   this.name = 'SequelizeValidationError';
   this.name = 'SequelizeValidationError';
   this.errors = errors || [];
   this.errors = errors || [];
-
-  return this;
 };
 };
-error.ValidationError.prototype = Object.create(error.BaseError.prototype, {
-  constructor: { value: error.ValidationError }
-});
+util.inherits(error.ValidationError, error.BaseError);
 
 
 /**
 /**
  * Finds all validation error items for the path specified.
  * Finds all validation error items for the path specified.

test/error.test.js

@@ -31,7 +31,7 @@ describe(Support.getTestDialectTeaser("Sequelize Errors"), function () {
       expect(validationError).to.be.instanceOf(Sequelize.ValidationError);
       expect(validationError).to.be.instanceOf(Sequelize.ValidationError);
       expect(validationError).to.be.instanceOf(Error);
       expect(validationError).to.be.instanceOf(Error);
       expect(validationError).to.have.property('name', 'SequelizeValidationError');
       expect(validationError).to.have.property('name', 'SequelizeValidationError');
-      
+
       expect(instError).to.be.instanceOf(Sequelize.Error);
       expect(instError).to.be.instanceOf(Sequelize.Error);
       expect(instError).to.be.instanceOf(Error);
       expect(instError).to.be.instanceOf(Error);
       expect(instValidationError).to.be.instanceOf(Sequelize.ValidationError);
       expect(instValidationError).to.be.instanceOf(Sequelize.ValidationError);