Merge pull request #893 from durango/update-validation-fix

DAOFactory.update() will now skip validations for columns that we're not...

lib/dao-factory.js

@@ -664,7 +664,10 @@ module.exports = (function() {
     }
     }
 
 
     if (options.validate === true) {
     if (options.validate === true) {
-      var validate = this.build(attrValueHash).validate()
+      var build    = this.build(attrValueHash)
+        , attrKeys = Object.keys(attrValueHash)
+        , validate = build.validate({skip: Object.keys(build.dataValues).filter(function(val) { return attrKeys.indexOf(val) !== -1 })})
+
       if (validate !== null && Object.keys(validate).length > 0) {
       if (validate !== null && Object.keys(validate).length > 0) {
         return new Utils.CustomEventEmitter(function(emitter) {
         return new Utils.CustomEventEmitter(function(emitter) {
           emitter.emit('error', validate)
           emitter.emit('error', validate)

test/dao.validations.test.js

@@ -254,6 +254,34 @@ describe(Support.getTestDialectTeaser("DaoValidator"), function() {
     }
     }
 
 
     describe('#update', function() {
     describe('#update', function() {
+      it('should allow us to update specific columns without tripping the validations', function(done) {
+        var User = this.sequelize.define('model', {
+          username: Sequelize.STRING,
+          email: {
+            type: Sequelize.STRING,
+            allowNull: false,
+            validate: {
+              isEmail: {
+                msg: 'You must enter a valid email address'
+              }
+            }
+          }
+        })
+
+        User.sync({ force: true }).success(function() {
+          User.create({username: 'bob', email: 'hello@world.com'}).success(function(user) {
+            User.update({username: 'toni'}, {id: user.id})
+            .error(function(err) { console.log(err) })
+            .success(function() {
+              User.find(1).success(function(user) {
+                expect(user.username).to.equal('toni')
+                done()
+              })
+            })
+          })
+        })
+      })
+
       it('should be able to emit an error upon updating when a validation has failed from an instance', function(done) {
       it('should be able to emit an error upon updating when a validation has failed from an instance', function(done) {
         var Model = this.sequelize.define('model', {
         var Model = this.sequelize.define('model', {
           name: {
           name: {