Merge pull request #793 from durango/mysql-text

MySQL will no longer try to create a text/blob column with a default value (there's no such thing). Closes #785

lib/dialects/mysql/query-generator.js

@@ -520,7 +520,8 @@ module.exports = (function() {
             template += " auto_increment"
             template += " auto_increment"
           }
           }
 
 
-          if ((dataType.defaultValue !== undefined) && (dataType.defaultValue != DataTypes.NOW)) {
+          // Blobs/texts cannot have a defaultValue
+          if (dataType.type !== "TEXT" && dataType.type._binary !== true && (dataType.defaultValue !== undefined) && (dataType.defaultValue != DataTypes.NOW)) {
             template += " DEFAULT " + this.escape(dataType.defaultValue)
             template += " DEFAULT " + this.escape(dataType.defaultValue)
           }
           }
 
 

test/mysql/dao-factory.test.js

@@ -71,6 +71,18 @@ if (dialect.match(/^mysql/)) {
         expect(User.attributes).to.deep.equal({id:"INTEGER NOT NULL auto_increment PRIMARY KEY", deleted_at:"DATETIME", updated_at:"DATETIME NOT NULL", created_at:"DATETIME NOT NULL"})
         expect(User.attributes).to.deep.equal({id:"INTEGER NOT NULL auto_increment PRIMARY KEY", deleted_at:"DATETIME", updated_at:"DATETIME NOT NULL", created_at:"DATETIME NOT NULL"})
         done()
         done()
       })
       })
+
+      it('omits text fields with defaultValues', function(done) {
+        var User = this.sequelize.define('User' + config.rand(), {name: {type: DataTypes.TEXT, defaultValue: 'helloworld'}})
+        expect(User.attributes.name).to.equal('TEXT')
+        done()
+      })
+
+      it('omits blobs fields with defaultValues', function(done) {
+        var User = this.sequelize.define('User' + config.rand(), {name: {type: DataTypes.STRING.BINARY, defaultValue: 'helloworld'}})
+        expect(User.attributes.name).to.equal('VARCHAR(255) BINARY')
+        done()
+      })
     })
     })
 
 
     describe('primaryKeys', function() {
     describe('primaryKeys', function() {

test/mysql/query-generator.test.js

@@ -68,7 +68,7 @@ if (dialect.match(/^mysql/)) {
         {
         {
           arguments: [{id: {type: 'INTEGER', allowNull: false, autoIncrement: true, defaultValue: 1, references: 'Bar', onDelete: 'CASCADE', onUpdate: 'RESTRICT'}}],
           arguments: [{id: {type: 'INTEGER', allowNull: false, autoIncrement: true, defaultValue: 1, references: 'Bar', onDelete: 'CASCADE', onUpdate: 'RESTRICT'}}],
           expectation: {id: 'INTEGER NOT NULL auto_increment DEFAULT 1 REFERENCES `Bar` (`id`) ON DELETE CASCADE ON UPDATE RESTRICT'}
           expectation: {id: 'INTEGER NOT NULL auto_increment DEFAULT 1 REFERENCES `Bar` (`id`) ON DELETE CASCADE ON UPDATE RESTRICT'}
-        },
+        }
       ],
       ],
 
 
       createTableQuery: [
       createTableQuery: [