Skip to content
Toggle navigation
Projects
Groups
Snippets
Help
public
/
sequelize
This project
Loading...
Sign in
Toggle navigation
Go to a project
Project
Repository
Issues
0
Merge Requests
0
Pipelines
Wiki
Snippets
Settings
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
不要怂,就是干,撸起袖子干!
Commit 850c7fd0
authored
Apr 10, 2019
by
Sushant
Committed by
GitHub
Apr 10, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
feat(postgres): enable standard conforming strings when required (#10746)
1 parent
7c3c18a9
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
33 additions
and
6 deletions
lib/dialects/abstract/connection-manager.js
lib/dialects/postgres/connection-manager.js
lib/dialects/abstract/connection-manager.js
View file @
850c7fd
...
...
@@ -256,7 +256,10 @@ class ConnectionManager {
//avoiding a useless round trip
if
(
this
.
sequelize
.
options
.
databaseVersion
===
0
)
{
return
this
.
sequelize
.
databaseVersion
(
_options
).
then
(
version
=>
{
this
.
sequelize
.
options
.
databaseVersion
=
semver
.
valid
(
version
)
?
version
:
this
.
defaultVersion
;
const
parsedVersion
=
_
.
get
(
semver
.
coerce
(
version
),
'version'
)
||
version
;
this
.
sequelize
.
options
.
databaseVersion
=
semver
.
valid
(
parsedVersion
)
?
parsedVersion
:
this
.
defaultVersion
;
this
.
versionPromise
=
null
;
return
this
.
_disconnect
(
connection
);
});
...
...
lib/dialects/postgres/connection-manager.js
View file @
850c7fd
...
...
@@ -122,6 +122,23 @@ class ConnectionManager extends AbstractConnectionManager {
let
responded
=
false
;
const
connection
=
new
this
.
lib
.
Client
(
connectionConfig
);
const
parameterHandler
=
message
=>
{
switch
(
message
.
parameterName
)
{
case
'server_version'
:
if
(
this
.
sequelize
.
options
.
databaseVersion
===
0
)
{
const
version
=
semver
.
coerce
(
message
.
parameterValue
).
version
;
this
.
sequelize
.
options
.
databaseVersion
=
semver
.
valid
(
version
)
?
version
:
this
.
defaultVersion
;
}
break
;
case
'standard_conforming_strings'
:
connection
[
'standard_conforming_strings'
]
=
message
.
parameterValue
;
break
;
}
};
const
endHandler
=
()
=>
{
debug
(
'connection timeout'
);
if
(
!
responded
)
{
...
...
@@ -133,8 +150,19 @@ class ConnectionManager extends AbstractConnectionManager {
// node-postgres does not treat this as an error since no active query was ever emitted
connection
.
once
(
'end'
,
endHandler
);
if
(
!
this
.
sequelize
.
config
.
native
)
{
// Receive various server parameters for further configuration
connection
.
connection
.
on
(
'parameterStatus'
,
parameterHandler
);
}
connection
.
connect
(
err
=>
{
responded
=
true
;
if
(
!
this
.
sequelize
.
config
.
native
)
{
// remove parameter handler
connection
.
connection
.
removeListener
(
'parameterStatus'
,
parameterHandler
);
}
if
(
err
)
{
if
(
err
.
code
)
{
switch
(
err
.
code
)
{
...
...
@@ -166,11 +194,7 @@ class ConnectionManager extends AbstractConnectionManager {
}).
tap
(
connection
=>
{
let
query
=
''
;
if
(
this
.
sequelize
.
options
.
databaseVersion
!==
0
&&
semver
.
gte
(
this
.
sequelize
.
options
.
databaseVersion
,
'8.2.0'
)
&&
semver
.
lt
(
this
.
sequelize
.
options
.
databaseVersion
,
'9.1.0'
)
)
{
if
(
connection
[
'standard_conforming_strings'
]
!==
'on'
)
{
// Disable escape characters in strings
// see https://github.com/sequelize/sequelize/issues/3545 (security issue)
// see https://www.postgresql.org/docs/current/static/runtime-config-compatible.html#GUC-STANDARD-CONFORMING-STRINGS
...
...
Write
Preview
Markdown
is supported
Attach a file
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to post a comment