Merge pull request #5115 from sushantdhiman/fix-1150

Fix(#1150) : Test to verify findAll / find properly clone options

test/unit/model/findall.test.js

@@ -6,7 +6,8 @@ var chai = require('chai')
   , Support = require(__dirname + '/../support')
   , Support = require(__dirname + '/../support')
   , current = Support.sequelize
   , current = Support.sequelize
   , sinon = require('sinon')
   , sinon = require('sinon')
-  , DataTypes = require(__dirname + '/../../../lib/data-types');
+  , DataTypes = require(__dirname + '/../../../lib/data-types')
+  , _ = require('lodash');
 
 
 describe(Support.getTestDialectTeaser('Model'), function() {
 describe(Support.getTestDialectTeaser('Model'), function() {
   describe('method findAll', function () {
   describe('method findAll', function () {
@@ -87,6 +88,20 @@ describe(Support.getTestDialectTeaser('Model'), function() {
           ]);
           ]);
         });
         });
       });
       });
+
+      it('properly clones options values', function() {
+        var options = {
+          attributes: {
+            exclude: ['name'],
+            include: ['name']
+          }
+        };
+        var optionsClones = _.cloneDeep(options);
+        return Model.findAll(options).bind(this).then(function () {
+          expect(options).to.deep.equal(optionsClones);
+        });
+      });
+
     });
     });
   });
   });
 });
 });

test/unit/model/findone.test.js

@@ -7,7 +7,8 @@ var chai = require('chai')
   , current = Support.sequelize
   , current = Support.sequelize
   , sinon = require('sinon')
   , sinon = require('sinon')
   , DataTypes = require(__dirname + '/../../../lib/data-types')
   , DataTypes = require(__dirname + '/../../../lib/data-types')
-  , Promise = require('bluebird');
+  , Promise = require('bluebird')
+  , _ = require('lodash');
 
 
 describe(Support.getTestDialectTeaser('Model'), function() {
 describe(Support.getTestDialectTeaser('Model'), function() {
   describe('method findOne', function () {
   describe('method findOne', function () {
@@ -67,5 +68,16 @@ describe(Support.getTestDialectTeaser('Model'), function() {
         expect(this.stub.getCall(0).args[0]).to.be.an('object').to.have.property('limit');
         expect(this.stub.getCall(0).args[0]).to.be.an('object').to.have.property('limit');
       });
       });
     });
     });
+
+    it('properly clones options values', function() {
+      var options = { where: { id: { $gt: 42 }}}
+        , optionsClones = _.cloneDeep(options)
+        , Model = current.define('model');
+
+      return Model.findOne(options).bind(this).then(function () {
+        expect(options).to.deep.equal(optionsClones);
+      });
+    });
+
   });
   });
 });
 });