Skip to content

public / sequelize

Go to a project

不要怂，就是干，撸起袖子干！

Commit 8cbd6a67 by Jan Aagaard Meier
Options

Refactored .query for all dialects to return promises

1 parent 0c114c36
Expand all
Inline Side-by-side
Showing with 158 additions and 134 deletions
lib/dialects/mariadb/connector-manager.js
......@@ -159,54 +159,88 @@ module.exports = (function() {
Utils._.extend(ConnectorManager.prototype, require("../abstract/connector-manager").prototype)
ConnectorManager.prototype.query = function(sql, callee, options) {
if (!this.isConnected && !this.pool) {
this.connect()
}
var self = this
options = options || {}
if (this.useQueue) {
// If queueing we'll let the execQueueItem method handle connecting
var queueItem = {
query: new Query(this.client, this.sequelize, callee, options || {}),
client: this.client,
query: new Query(null, this.sequelize, callee, options),
sql: sql
}
};
queueItem.query.options.uuid = this.config.uuid
enqueue.call(this, queueItem, options)
return queueItem.query
return queueItem.query.promise.finally(function () {
afterQuery.call(self, queueItem)
})
}
var self = this
, query = new Query(this.client, this.sequelize, callee, options || {})
this.pendingQueries++
query.done(function() {
self.pendingQueries--
if (self.pool) {
self.pool.release(query.client)
} else {
if (self.pendingQueries === 0) {
setTimeout(function() {
self.pendingQueries === 0 && self.disconnect.call(self)
}, 100)
var query = new Query(null, this.sequelize, callee, options);
this.pendingQueries++;
query.options.uuid = this.config.uuid
return this.getConnection(options).then(function (client) {
query.client = client
return query.run(sql).finally(function () {
self.pendingQueries--;
if (self.pool) {
self.pool.release(query.client);
} else {
if (self.pendingQueries === 0) {
setTimeout(function() {
if (self.pendingQueries === 0){
self.disconnect.call(self);
}
}, 100);
}
}
}
});
})
};
ConnectorManager.prototype.getConnection = function(options) {
var self = this;
if (!this.pool) {
query.run(sql)
} else {
this.pool.acquire(function(err, client) {
if (err) {
return query.emit('error', err)
}
options = options || {}
query.client = client
query.run(sql)
return
}, undefined, options.type)
}
return new Utils.Promise(function (resolve, reject) {
if (!self.pool) {
// Regular client caching
if (self.client) {
return resolve(self.client);
} else {
// Cache for concurrent queries
if (self._getConnection) {
return resolve(self._getConnection)
}
return query
}
// Set cache and acquire connection
self._getConnection = this;
connect.call(self, function(err, client) {
if (err) {
return reject(err);
}
// Unset caching, should now be caught by the self.client check
self._getConnection = null;
self.client = client;
resolve(client);
});
}
} else {
// Acquire from pool
self.pool.acquire(function(err, client) {
if (err) {
return reject(err);
}
resolve(client);
}, options.priority, options.type);
}
})
};
ConnectorManager.prototype.connect = function() {
var self = this
......@@ -228,10 +262,12 @@ module.exports = (function() {
return
}
// private
var disconnect = function(client) {
if (!client) {
return // TODO possible orphaning of clients?
}
var self = this
if (!this.useQueue) {
this.client = null
......@@ -257,7 +293,7 @@ module.exports = (function() {
var connect = function(done, config) {
config = config || this.config
var self = this
, client
......@@ -324,7 +360,7 @@ module.exports = (function() {
var self = this
this.pool.acquire(function(err, client) {
if (err) {
queueItem.query.emit('error', err)
queueItem.query.reject(err)
return
}
//we set the client here, asynchronously, when getting a pooled connection
......@@ -367,12 +403,6 @@ module.exports = (function() {
var execQueueItem = function(queueItem) {
var self = this
queueItem.query
.success(function(){ afterQuery.call(self, queueItem) })
.error(function(){ afterQuery.call(self, queueItem) })
queueItem.query.run(queueItem.sql, queueItem.client)
}
......
lib/dialects/mariadb/query.js
......@@ -12,7 +12,12 @@ module.exports = (function() {
raw: false
}, options || {})
var self = this
this.checkLoggingOption()
this.promise = new Utils.Promise(function (resolve, reject) {
self.resolve = resolve
self.reject = reject
})
}
Utils.inherit(Query, AbstractQuery)
......@@ -87,9 +92,9 @@ module.exports = (function() {
})
.on('error', function(err) {
errorDetected = true
self.emit('sql', self.sql)
self.promise.emit('sql', self.sql)
err.sql = sql
self.emit('error', err, self.callee)
self.reject(err)
})
.on('end', function(info) {
if (alreadyEnded || errorDetected) {
......@@ -97,19 +102,18 @@ module.exports = (function() {
}
alreadyEnded = true
self.emit('sql', self.sql)
self.promise.emit('sql', self.sql)
// we need to figure out whether to send the result set
// or info depending upon the type of query
if (/^call/.test(self.sql.toLowerCase())) {
self.emit('success', resultSet)
self.resolve(resultSet)
} else if( /^show/.test(self.sql.toLowerCase()) ||
/^select/.test(self.sql.toLowerCase()) ||
/^describe/.test(self.sql.toLowerCase())) {
self.emit('success', self.formatResults(resultSet))
self.resolve(self.formatResults(resultSet))
} else {
self.emit('success', self.formatResults(info))
self.resolve(self.formatResults(info))
}
})
})
.on('error', function(err) {
......@@ -117,12 +121,12 @@ module.exports = (function() {
return
}
errorDetected = true
self.emit('sql', self.sql)
self.emit('error', err, self.callee)
self.promise.emit('sql', self.sql)
self.reject(err)
})
.setMaxListeners(100)
return this
return this.promise
}
return Query
......
lib/dialects/mysql/connector-manager.js
......@@ -2,7 +2,7 @@ var mysql
, Pooling = require('generic-pool')
, Query = require("./query")
, Utils = require("../../utils")
, without = function(arr, elem) { return arr.filter(function(e) { return e != elem }) }
, without = function(arr, elem) { return arr.filter(function(e) { return e.query.uuid != elem.query.uuid }) }
module.exports = (function() {
var ConnectorManager = function(sequelize, config) {
......@@ -160,79 +160,75 @@ module.exports = (function() {
Utils._.extend(ConnectorManager.prototype, require("../abstract/connector-manager").prototype);
ConnectorManager.prototype.query = function(sql, callee, options) {
var self = this
options = options || {}
if (this.useQueue) {
// If queueing we'll let the execQueueItem method handle connecting
var queueItem = {
query: new Query(null, this.sequelize, callee, options || {}),
query: new Query(null, this.sequelize, callee, options),
sql: sql
};
queueItem.query.options.uuid = this.config.uuid
enqueue.call(this, queueItem, options);
return queueItem.query;
enqueue.call(this, queueItem, options)
return queueItem.query.promise.finally(function () {
afterQuery.call(self, queueItem)
})
}
var self = this, query = new Query(null, this.sequelize, callee, options || {});
var query = new Query(null, this.sequelize, callee, options);
this.pendingQueries++;
query.options.uuid = this.config.uuid
query.done(function() {
self.pendingQueries--;
if (self.pool) {
self.pool.release(query.client);
} else {
if (self.pendingQueries === 0) {
setTimeout(function() {
if (self.pendingQueries === 0){
self.disconnect.call(self);
}
}, 100);
}
}
});
this.getConnection(options, function (err, client) {
if (err) {
return query.emit('error', err)
}
return this.getConnection(options).then(function (client) {
query.client = client
query.run(sql)
});
return query;
return query.run(sql).finally(function () {
self.pendingQueries--;
if (self.pool) {
self.pool.release(query.client);
} else {
if (self.pendingQueries === 0) {
setTimeout(function() {
if (self.pendingQueries === 0){
self.disconnect.call(self);
}
}, 100);
}
}
});
})
};
ConnectorManager.prototype.getConnection = function(options, callback) {
ConnectorManager.prototype.getConnection = function(options) {
var self = this;
if (typeof options === "function") {
callback = options;
options = {};
}
options = options || {}
return new Utils.CustomEventEmitter(function (emitter) {
return new Utils.Promise(function (resolve, reject) {
if (!self.pool) {
// Regular client caching
if (self.client) {
return emitter.emit('success', self.client);
return resolve(self.client);
} else {
// Cache for concurrent queries
if (self._getConnection) {
self._getConnection.proxy(emitter);
return;
return resolve(self._getConnection)
}
// Set cache and acquire connection
self._getConnection = emitter;
self._getConnection = this;
connect.call(self, function(err, client) {
if (err) {
return emitter.emit('error', err);
return reject(err);
}
// Unset caching, should now be caught by the self.client check
self._getConnection = null;
self.client = client;
emitter.emit('success', client);
resolve(client);
});
}
}
......@@ -240,12 +236,12 @@ module.exports = (function() {
// Acquire from pool
self.pool.acquire(function(err, client) {
if (err) {
return emitter.emit('error', err);
return reject(err);
}
emitter.emit('success', client);
resolve(client);
}, options.priority, options.type);
}
}).run().done(callback);
})
};
ConnectorManager.prototype.disconnect = function() {
......@@ -255,13 +251,15 @@ module.exports = (function() {
return
};
// private
var disconnect = function(client) {
var self = this;
this.client = null;
if (!client) {
return
}
client.end(function() {
if (!self.useQueue) {
return client.destroy();
......@@ -269,7 +267,6 @@ module.exports = (function() {
var intervalObj = null
var cleanup = function () {
var retryCt = 0
// make sure to let client finish before calling destroy
if (client._queue && (client._queue.length > 0)) {
return
......@@ -287,7 +284,6 @@ module.exports = (function() {
var connect = function(done, config) {
config = config || this.config
var emitter = new (require('events').EventEmitter)()
var connectionConfig = {
host: config.host,
port: config.port,
......@@ -309,22 +305,22 @@ module.exports = (function() {
switch(err.code) {
case 'ECONNREFUSED':
case 'ER_ACCESS_D2ENIED_ERROR':
emitter.emit('error', 'Failed to authenticate for MySQL. Please double check your settings.')
done('Failed to authenticate for MySQL. Please double check your settings.')
break
case 'ENOTFOUND':
case 'EHOSTUNREACH':
case 'EINVAL':
emitter.emit('error', 'Failed to find MySQL server. Please double check your settings.')
done('Failed to find MySQL server. Please double check your settings.')
break
default:
emitter.emit('error', err);
done(err);
break;
}
return;
}
emitter.emit('success', connection);
done(null, connection);
})
connection.query("SET time_zone = '+0:00'");
......@@ -333,13 +329,6 @@ module.exports = (function() {
if (config.pool !== null && config.pool.handleDisconnects) {
handleDisconnect(this.pool, connection)
}
emitter.on('error', function (err) {
done(err);
});
emitter.on('success', function (connection) {
done(null, connection);
});
}
var handleDisconnect = function(pool, client) {
......@@ -388,26 +377,17 @@ module.exports = (function() {
disconnectIfNoConnections.call(this)
}
var execQueueItem = function(queueItem) {
var self = this
self.getConnection({
this.getConnection({
priority: queueItem.query.options.priority,
type: queueItem.query.options.type
}, function (err, connection) {
if (err) {
queueItem.query.emit('error', err)
return
}
}).then(function (connection) {
queueItem.query.client = connection
queueItem.client = connection
queueItem.query
.success(function(){ afterQuery.call(self, queueItem) })
.error(function(){ afterQuery.call(self, queueItem) })
queueItem.query.run(queueItem.sql, queueItem.client)
queueItem.query.run(queueItem.sql)
}, function (err) {
queueItem.query.reject(err)
})
}
......@@ -421,7 +401,7 @@ module.exports = (function() {
})
ConnectorManager.prototype.__defineGetter__('isConnected', function() {
return this.client != null
return this.client !== null
})
var disconnectIfNoConnections = function() {
......
lib/dialects/mysql/query.js
var Utils = require("../../utils")
, AbstractQuery = require('../abstract/query')
, uuid = require('node-uuid')
module.exports = (function() {
var Query = function(client, sequelize, callee, options) {
this.client = client
this.callee = callee
this.sequelize = sequelize
this.uuid = uuid.v4()
this.options = Utils._.extend({
logging: console.log,
plain: false,
raw: false
}, options || {})
var self = this
this.checkLoggingOption()
this.promise = new Utils.Promise(function (resolve, reject) {
self.resolve = resolve
self.reject = reject
})
}
Utils.inherit(Query, AbstractQuery)
Query.prototype.run = function(sql) {
var self = this
this.sql = sql
if (this.options.logging !== false) {
this.sequelize.log('Executing (' + this.options.uuid + '): ' + this.sql)
}
this.client.query(this.sql, function(err, results, fields) {
this.emit('sql', this.sql, this.options.uuid)
self.client.query(self.sql, function(err, results, fields) {
self.promise.emit('sql', self.sql, self.options.uuid)
if (err) {
err.sql = sql
this.emit('error', err)
self.reject(err)
} else {
this.emit('success', this.formatResults(results))
self.resolve(self.formatResults(results))
}
}.bind(this)).setMaxListeners(100)
return this
}).setMaxListeners(100)
return this.promise
}
return Query
......
Markdown is supported
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!