Skip to content

public / sequelize

Go to a project

不要怂，就是干，撸起袖子干！

Commit 9b204af6 by Muhammad AbdulMoiz Committed by Sushant
Options

try catch block added for formatting parameters process (#6999) 

* try catch block added for formatting parameters process

* new line space added before braces

* query function processing wrapped to Promise.try

* processQuery method removed from var

* binding context changed to arrow function

* promise.try chaining added

* extra Promise.resolve removed code refactored

* space added

* test cases for 'query' method updated with respect to new rejection structure instead of throwing error

* it block messages corrected

* return added and code structured

* line space added

* line space added

* code style fixed
1 parent cc09a3c7
Inline Side-by-side
Showing with 72 additions and 119 deletions
lib/sequelize.js
...@@ -455,12 +455,11 @@ class Sequelize { ...@@ -455,12 +455,11 @@ class Sequelize {
* *
* @see {@link Model#build} for more information about instance option. * @see {@link Model#build} for more information about instance option.
*/ */
query(sql, options) { query(sql, options) {
if (arguments.length > 2) { let bindParameters;
// TODO: Remove this note in the next major version (4.0)
throw new Error('Sequelize.query was refactored to only use the parameters `sql` and `options`. Please read the changelog about BC.');
}
return Promise.try(() => {
options = _.assign({}, this.options.query, options); options = _.assign({}, this.options.query, options);
if (options.instance && !options.model) { if (options.instance && !options.model) {
...@@ -477,7 +476,6 @@ class Sequelize { ...@@ -477,7 +476,6 @@ class Sequelize {
if (options.replacements !== undefined) { if (options.replacements !== undefined) {
throw new Error('Both `sql.values` and `options.replacements` cannot be set at the same time'); throw new Error('Both `sql.values` and `options.replacements` cannot be set at the same time');
} }
options.replacements = sql.values; options.replacements = sql.values;
} }
...@@ -485,7 +483,6 @@ class Sequelize { ...@@ -485,7 +483,6 @@ class Sequelize {
if (options.bind !== undefined) { if (options.bind !== undefined) {
throw new Error('Both `sql.bind` and `options.bind` cannot be set at the same time'); throw new Error('Both `sql.bind` and `options.bind` cannot be set at the same time');
} }
options.bind = sql.bind; options.bind = sql.bind;
} }
...@@ -503,15 +500,15 @@ class Sequelize { ...@@ -503,15 +500,15 @@ class Sequelize {
if (options.replacements && options.bind) { if (options.replacements && options.bind) {
throw new Error('Both `replacements` and `bind` cannot be set at the same time'); throw new Error('Both `replacements` and `bind` cannot be set at the same time');
} }
if (options.replacements) { if (options.replacements) {
if (Array.isArray(options.replacements)) { if (Array.isArray(options.replacements)) {
sql = Utils.format([sql].concat(options.replacements), this.options.dialect); sql = Utils.format([sql].concat(options.replacements), this.options.dialect);
} } else {
else {
sql = Utils.formatNamedParameters(sql, options.replacements, this.options.dialect); sql = Utils.formatNamedParameters(sql, options.replacements, this.options.dialect);
} }
} }
let bindParameters;
if (options.bind) { if (options.bind) {
const bindSql = this.dialect.Query.formatBindParameters(sql, options.bind, this.options.dialect); const bindSql = this.dialect.Query.formatBindParameters(sql, options.bind, this.options.dialect);
sql = bindSql[0]; sql = bindSql[0];
...@@ -555,12 +552,10 @@ class Sequelize { ...@@ -555,12 +552,10 @@ class Sequelize {
//then set to DEFAULT if none is provided //then set to DEFAULT if none is provided
options.searchPath = 'DEFAULT'; options.searchPath = 'DEFAULT';
} }
return options.transaction ? options.transaction.connection : this.connectionManager.getConnection(options);
return Promise.resolve( }).then(connection => {
options.transaction ? options.transaction.connection : this.connectionManager.getConnection(options)
).then(connection => {
const query = new this.dialect.Query(connection, this, options); const query = new this.dialect.Query(connection, this, options);
return retry(() => query.run(sql, bindParameters).finally(() => { return retry(() => query.run(sql, bindParameters).finally(() => {
if (!options.transaction) { if (!options.transaction) {
return this.connectionManager.releaseConnection(connection); return this.connectionManager.releaseConnection(connection);
......
test/integration/sequelize.test.js
...@@ -425,46 +425,34 @@ describe(Support.getTestDialectTeaser('Sequelize'), function() { ...@@ -425,46 +425,34 @@ describe(Support.getTestDialectTeaser('Sequelize'), function() {
}); });
}); });
it('throw an exception if `values` and `options.replacements` are both passed', function() { it('reject if `values` and `options.replacements` are both passed', function() {
var self = this; return this.sequelize.query({ query: 'select ? as foo, ? as bar', values: [1, 2] }, { raw: true, replacements: [1, 2] })
expect(function() { .should.be.rejectedWith(Error, 'Both `sql.values` and `options.replacements` cannot be set at the same time');
return self.sequelize.query({ query: 'select ? as foo, ? as bar', values: [1, 2] }, { raw: true, replacements: [1, 2] });
}).to.throw(Error, 'Both `sql.values` and `options.replacements` cannot be set at the same time');
}); });
it('throw an exception if `sql.bind` and `options.bind` are both passed', function() { it('reject if `sql.bind` and `options.bind` are both passed', function() {
var self = this; return this.sequelize.query({ query: 'select $1 + ? as foo, $2 + ? as bar', bind: [1, 2] }, { raw: true, bind: [1, 2] })
expect(function() { .should.be.rejectedWith(Error, 'Both `sql.bind` and `options.bind` cannot be set at the same time');
return self.sequelize.query({ query: 'select $1 + ? as foo, $2 + ? as bar', bind: [1, 2] }, { raw: true, bind: [1, 2] });
}).to.throw(Error, 'Both `sql.bind` and `options.bind` cannot be set at the same time');
}); });
it('throw an exception if `options.replacements` and `options.bind` are both passed', function() { it('reject if `options.replacements` and `options.bind` are both passed', function() {
var self = this; return this.sequelize.query('select $1 + ? as foo, $2 + ? as bar', { raw: true, bind: [1, 2], replacements: [1, 2] })
expect(function() { .should.be.rejectedWith(Error, 'Both `replacements` and `bind` cannot be set at the same time');
return self.sequelize.query('select $1 + ? as foo, $2 + ? as bar', { raw: true, bind: [1, 2], replacements: [1, 2] });
}).to.throw(Error, 'Both `replacements` and `bind` cannot be set at the same time');
}); });
it('throw an exception if `sql.bind` and `sql.values` are both passed', function() { it('reject if `sql.bind` and `sql.values` are both passed', function() {
var self = this; return this.sequelize.query({ query: 'select $1 + ? as foo, $2 + ? as bar', bind: [1, 2], values: [1, 2] }, { raw: true })
expect(function() { .should.be.rejectedWith(Error, 'Both `replacements` and `bind` cannot be set at the same time');
return self.sequelize.query({ query: 'select $1 + ? as foo, $2 + ? as bar', bind: [1, 2], values: [1, 2] }, { raw: true });
}).to.throw(Error, 'Both `replacements` and `bind` cannot be set at the same time');
}); });
it('throw an exception if `sql.bind` and `options.replacements`` are both passed', function() { it('reject if `sql.bind` and `options.replacements`` are both passed', function() {
var self = this; return this.sequelize.query({ query: 'select $1 + ? as foo, $2 + ? as bar', bind: [1, 2] }, { raw: true, replacements: [1, 2] })
expect(function() { .should.be.rejectedWith(Error, 'Both `replacements` and `bind` cannot be set at the same time');
return self.sequelize.query({ query: 'select $1 + ? as foo, $2 + ? as bar', bind: [1, 2] }, { raw: true, replacements: [1, 2] });
}).to.throw(Error, 'Both `replacements` and `bind` cannot be set at the same time');
}); });
it('throw an exception if `options.bind` and `sql.replacements` are both passed', function() { it('reject if `options.bind` and `sql.replacements` are both passed', function() {
var self = this; return this.sequelize.query({ query: 'select $1 + ? as foo, $1 _ ? as bar', values: [1, 2] }, { raw: true, bind: [1, 2] })
expect(function() { .should.be.rejectedWith(Error, 'Both `replacements` and `bind` cannot be set at the same time');
return self.sequelize.query({ query: 'select $1 + ? as foo, $1 _ ? as bar', values: [1, 2] }, { raw: true, bind: [1, 2] });
}).to.throw(Error, 'Both `replacements` and `bind` cannot be set at the same time');
}); });
it('properly adds and escapes replacement value', function () { it('properly adds and escapes replacement value', function () {
...@@ -580,39 +568,29 @@ describe(Support.getTestDialectTeaser('Sequelize'), function() { ...@@ -580,39 +568,29 @@ describe(Support.getTestDialectTeaser('Sequelize'), function() {
.to.eventually.deep.equal([{ foo: 1, bar: null }]); .to.eventually.deep.equal([{ foo: 1, bar: null }]);
}); });
it('throw an exception when key is missing in the passed object', function() { it('reject when key is missing in the passed object', function() {
var self = this; return this.sequelize.query('select :one as foo, :two as bar, :three as baz', { raw: true, replacements: { one: 1, two: 2 }})
expect(function() { .should.be.rejectedWith(Error, /Named parameter ":\w+" has no value in the given object\./g);
self.sequelize.query('select :one as foo, :two as bar, :three as baz', { raw: true, replacements: { one: 1, two: 2 }});
}).to.throw(Error, /Named parameter ":\w+" has no value in the given object\./g);
}); });
it('throw an exception with the passed number', function() { it('reject with the passed number', function() {
var self = this; return this.sequelize.query('select :one as foo, :two as bar', { raw: true, replacements: 2 })
expect(function() { .should.be.rejectedWith(Error, /Named parameter ":\w+" has no value in the given object\./g);
self.sequelize.query('select :one as foo, :two as bar', { raw: true, replacements: 2 });
}).to.throw(Error, /Named parameter ":\w+" has no value in the given object\./g);
}); });
it('throw an exception with the passed empty object', function() { it('reject with the passed empty object', function() {
var self = this; return this.sequelize.query('select :one as foo, :two as bar', { raw: true, replacements: {}})
expect(function() { .should.be.rejectedWith(Error, /Named parameter ":\w+" has no value in the given object\./g);
self.sequelize.query('select :one as foo, :two as bar', { raw: true, replacements: {}});
}).to.throw(Error, /Named parameter ":\w+" has no value in the given object\./g);
}); });
it('throw an exception with the passed string', function() { it('reject with the passed string', function() {
var self = this; return this.sequelize.query('select :one as foo, :two as bar', { raw: true, replacements: 'foobar'})
expect(function() { .should.be.rejectedWith(Error, /Named parameter ":\w+" has no value in the given object\./g);
self.sequelize.query('select :one as foo, :two as bar', { raw: true, replacements: 'foobar'});
}).to.throw(Error, /Named parameter ":\w+" has no value in the given object\./g);
}); });
it('throw an exception with the passed date', function() { it('reject with the passed date', function() {
var self = this; return this.sequelize.query('select :one as foo, :two as bar', { raw: true, replacements: new Date()})
expect(function() { .should.be.rejectedWith(Error, /Named parameter ":\w+" has no value in the given object\./g);
self.sequelize.query('select :one as foo, :two as bar', { raw: true, replacements: new Date()});
}).to.throw(Error, /Named parameter ":\w+" has no value in the given object\./g);
}); });
it('binds token with the passed array', function() { it('binds token with the passed array', function() {
...@@ -689,78 +667,58 @@ describe(Support.getTestDialectTeaser('Sequelize'), function() { ...@@ -689,78 +667,58 @@ describe(Support.getTestDialectTeaser('Sequelize'), function() {
}); });
} }
it('throw an exception when binds passed with object and numeric $1 is also present', function() { it('reject when binds passed with object and numeric $1 is also present', function() {
var self = this;
var typeCast = (dialect === 'postgres') ? '::int' : ''; var typeCast = (dialect === 'postgres') ? '::int' : '';
var logSql; var logSql;
expect(function() { return this.sequelize.query('select $one'+typeCast+' as foo, $two'+typeCast+' as bar, \'$1\' as baz', { raw: true, bind: { one: 1, two: 2 }, logging: function(s) { logSql = s; } })
self.sequelize.query('select $one'+typeCast+' as foo, $two'+typeCast+' as bar, \'$1\' as baz', { raw: true, bind: { one: 1, two: 2 }, logging: function(s) { logSql = s; } }); .should.be.rejectedWith(Error, /Named bind parameter "\$\w+" has no value in the given object\./g);
}).to.throw(Error, /Named bind parameter "\$\w+" has no value in the given object\./g);
}); });
it('throw an exception when binds passed as array and $alpha is also present', function() { it('reject when binds passed as array and $alpha is also present', function() {
var self = this;
var typeCast = (dialect === 'postgres') ? '::int' : ''; var typeCast = (dialect === 'postgres') ? '::int' : '';
var logSql; var logSql;
expect(function() { return this.sequelize.query('select $1'+typeCast+' as foo, $2'+typeCast+' as bar, \'$foo\' as baz', { raw: true, bind: [1, 2], logging: function(s) { logSql = s; } })
self.sequelize.query('select $1'+typeCast+' as foo, $2'+typeCast+' as bar, \'$foo\' as baz', { raw: true, bind: [1, 2], logging: function(s) { logSql = s; } }); .should.be.rejectedWith(Error, /Named bind parameter "\$\w+" has no value in the given object\./g);
}).to.throw(Error, /Named bind parameter "\$\w+" has no value in the given object\./g);
}); });
it('throw an exception when bind key is $0 with the passed array', function() { it('reject when bind key is $0 with the passed array', function() {
var self = this; return this.sequelize.query('select $1 as foo, $0 as bar, $3 as baz', { raw: true, bind: [1, 2] })
expect(function() { .should.be.rejectedWith(Error, /Named bind parameter "\$\w+" has no value in the given object\./g);
self.sequelize.query('select $1 as foo, $0 as bar, $3 as baz', { raw: true, bind: [1, 2] });
}).to.throw(Error, /Named bind parameter "\$\w+" has no value in the given object\./g);
}); });
it('throw an exception when bind key is $01 with the passed array', function() { it('reject when bind key is $01 with the passed array', function() {
var self = this; return this.sequelize.query('select $1 as foo, $01 as bar, $3 as baz', { raw: true, bind: [1, 2] })
expect(function() { .should.be.rejectedWith(Error, /Named bind parameter "\$\w+" has no value in the given object\./g);
self.sequelize.query('select $1 as foo, $01 as bar, $3 as baz', { raw: true, bind: [1, 2] });
}).to.throw(Error, /Named bind parameter "\$\w+" has no value in the given object\./g);
}); });
it('throw an exception when bind key is missing in the passed array', function() { it('reject when bind key is missing in the passed array', function() {
var self = this; return this.sequelize.query('select $1 as foo, $2 as bar, $3 as baz', { raw: true, bind: [1, 2] })
expect(function() { .should.be.rejectedWith(Error, /Named bind parameter "\$\w+" has no value in the given object\./g);
self.sequelize.query('select $1 as foo, $2 as bar, $3 as baz', { raw: true, bind: [1, 2] });
}).to.throw(Error, /Named bind parameter "\$\w+" has no value in the given object\./g);
}); });
it('throw an exception when bind key is missing in the passed object', function() { it('reject when bind key is missing in the passed object', function() {
var self = this; return this.sequelize.query('select $one as foo, $two as bar, $three as baz', { raw: true, bind: { one: 1, two: 2 }})
expect(function() { .should.be.rejectedWith(Error, /Named bind parameter "\$\w+" has no value in the given object\./g);
self.sequelize.query('select $one as foo, $two as bar, $three as baz', { raw: true, bind: { one: 1, two: 2 }});
}).to.throw(Error, /Named bind parameter "\$\w+" has no value in the given object\./g);
}); });
it('throw an exception with the passed number for bind', function() { it('reject with the passed number for bind', function() {
var self = this; return this.sequelize.query('select $one as foo, $two as bar', { raw: true, bind: 2 })
expect(function() { .should.be.rejectedWith(Error, /Named bind parameter "\$\w+" has no value in the given object\./g);
self.sequelize.query('select $one as foo, $two as bar', { raw: true, bind: 2 });
}).to.throw(Error, /Named bind parameter "\$\w+" has no value in the given object\./g);
}); });
it('throw an exception with the passed empty object for bind', function() { it('reject with the passed empty object for bind', function() {
var self = this; return this.sequelize.query('select $one as foo, $two as bar', { raw: true, bind: {}})
expect(function() { .should.be.rejectedWith(Error, /Named bind parameter "\$\w+" has no value in the given object\./g);
self.sequelize.query('select $one as foo, $two as bar', { raw: true, bind: {}});
}).to.throw(Error, /Named bind parameter "\$\w+" has no value in the given object\./g);
}); });
it('throw an exception with the passed string for bind', function() { it('reject with the passed string for bind', function() {
var self = this; return this.sequelize.query('select $one as foo, $two as bar', { raw: true, bind: 'foobar'})
expect(function() { .should.be.rejectedWith(Error, /Named bind parameter "\$\w+" has no value in the given object\./g);
self.sequelize.query('select $one as foo, $two as bar', { raw: true, bind: 'foobar'});
}).to.throw(Error, /Named bind parameter "\$\w+" has no value in the given object\./g);
}); });
it('throw an exception with the passed date for bind', function() { it('reject with the passed date for bind', function() {
var self = this; return this.sequelize.query('select $one as foo, $two as bar', { raw: true, bind: new Date()})
expect(function() { .should.be.rejectedWith(Error, /Named bind parameter "\$\w+" has no value in the given object\./g);
self.sequelize.query('select $one as foo, $two as bar', { raw: true, bind: new Date()});
}).to.throw(Error, /Named bind parameter "\$\w+" has no value in the given object\./g);
}); });
it('handles AS in conjunction with functions just fine', function() { it('handles AS in conjunction with functions just fine', function() {
......
Markdown is supported
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!