Merge pull request #185 from vlmonk/undefined-value-bug

sqlite backend produce invalid sql if value is 'undefined'

lib/dialects/sqlite/query-generator.js

@@ -4,7 +4,7 @@ var Utils = require("../../utils")
 var escape = function(str) {
 var escape = function(str) {
   if (typeof str === 'string') {
   if (typeof str === 'string') {
     return "'" + str.replace(/'/g, "''") + "'"
     return "'" + str.replace(/'/g, "''") + "'"
-  } else if(str === null) {
+  } else if(str === null || str === undefined) {
     return 'NULL'
     return 'NULL'
   } else {
   } else {
     return str
     return str

spec-jasmine/sqlite/query-generator.spec.js

@@ -16,6 +16,12 @@ describe('QueryGenerator', function() {
       }, {
       }, {
         arguments: ['myTable', { name: "'bar'" }],
         arguments: ['myTable', { name: "'bar'" }],
         expectation: "INSERT INTO `myTable` (`name`) VALUES ('''bar''');"
         expectation: "INSERT INTO `myTable` (`name`) VALUES ('''bar''');"
+      }, {
+        arguments: ['myTable', { name: "bar", value: null }],
+        expectation: "INSERT INTO `myTable` (`name`,`value`) VALUES ('bar',NULL);"
+      }, {
+        arguments: ['myTable', { name: "bar", value: undefined }],
+        expectation: "INSERT INTO `myTable` (`name`,`value`) VALUES ('bar',NULL);"
       }
       }
     ],
     ],
 
 
@@ -26,6 +32,12 @@ describe('QueryGenerator', function() {
       }, {
       }, {
         arguments: ['myTable', { name: "'bar'" }, { id: 2 }],
         arguments: ['myTable', { name: "'bar'" }, { id: 2 }],
         expectation: "UPDATE `myTable` SET `name`='''bar''' WHERE `id`=2"
         expectation: "UPDATE `myTable` SET `name`='''bar''' WHERE `id`=2"
+      }, {
+        arguments: ['myTable', { name: 'bar', value: null }, { id: 2 }],
+        expectation: "UPDATE `myTable` SET `name`='bar',`value`=NULL WHERE `id`=2"
+      }, {
+        arguments: ['myTable', { name: 'bar', value: undefined }, { id: 2 }],
+        expectation: "UPDATE `myTable` SET `name`='bar',`value`=NULL WHERE `id`=2"
       }
       }
     ]
     ]
   };
   };