don't execute tests for every dialect but only for one per test run

changelog.md

 # v1.6.0 #
 # v1.6.0 #
 - [DEPENDENCIES] upgraded most dependencies. most important: mysql was upgraded to 2.0.0-alpha-3
 - [DEPENDENCIES] upgraded most dependencies. most important: mysql was upgraded to 2.0.0-alpha-3
+- [REFACTORING] separated tests for dialects
 - [BUG] fixed wrong version in sequelize binary
 - [BUG] fixed wrong version in sequelize binary
 - [FEATURE] added association prefetching for find and findAll
 - [FEATURE] added association prefetching for find and findAll
 - [FEATURE] it's now possible to use callbacks of async functions inside migrations (thanks to mphilpot)
 - [FEATURE] it's now possible to use callbacks of async functions inside migrations (thanks to mphilpot)
 - [FEATURE] improved comfort of sequelize.query. just pass an sql string to it and wait for the result
 - [FEATURE] improved comfort of sequelize.query. just pass an sql string to it and wait for the result
 - [FEATURE] Migrations now understand NODE_ENV (thanks to gavri)
 - [FEATURE] Migrations now understand NODE_ENV (thanks to gavri)
+- [FEATURE]
 
 
 # v1.5.0 #
 # v1.5.0 #
 - [REFACTORING] use underscore functions for Utils.isHash (thanks to Mick-Hansen/innofluence)
 - [REFACTORING] use underscore functions for Utils.isHash (thanks to Mick-Hansen/innofluence)

package.json

@@ -48,7 +48,10 @@
   "scripts": {
   "scripts": {
     "test": "npm run test-jasmine && npm run test-buster",
     "test": "npm run test-jasmine && npm run test-buster",
     "test-jasmine": "./node_modules/.bin/jasmine-node spec-jasmine/",
     "test-jasmine": "./node_modules/.bin/jasmine-node spec-jasmine/",
-    "test-buster": "./node_modules/.bin/buster-test",
+    "test-buster": "npm run test-buster-mysql && npm run test-buster-postgres && npm run test-buster-sqlite",
+    "test-buster-mysql": "DIALECT=mysql ./node_modules/.bin/buster-test",
+    "test-buster-postgres": "DIALECT=postgres ./node_modules/.bin/buster-test",
+    "test-buster-sqlite": "DIALECT=sqlite ./node_modules/.bin/buster-test",
     "generate-docs": "node_modules/.bin/dox-foundation --source ./lib --title Sequelize"
     "generate-docs": "node_modules/.bin/dox-foundation --source ./lib --title Sequelize"
   },
   },
   "bin": {
   "bin": {

spec/associations/belongs-to.spec.js

@@ -2,45 +2,43 @@ if (typeof require === 'function') {
   const buster    = require("buster")
   const buster    = require("buster")
       , Helpers   = require('../buster-helpers')
       , Helpers   = require('../buster-helpers')
       , Sequelize = require('../../index')
       , Sequelize = require('../../index')
-      , dialects  = Helpers.getSupportedDialects()
+      , dialect   = Helpers.getTestDialect()
 }
 }
 
 
 buster.spec.expose()
 buster.spec.expose()
 buster.testRunner.timeout = 500
 buster.testRunner.timeout = 500
 
 
-dialects.forEach(function(dialect) {
-  describe('BelongsTo@' + dialect, function() {
-    before(function(done) {
-      Helpers.initTests({
-        beforeComplete: function(sequelize) {
-          this.sequelize = sequelize
-        }.bind(this),
-        onComplete: done
-      })
+describe("[" + dialect.toUpperCase() + "] BelongsTo", function() {
+  before(function(done) {
+    Helpers.initTests({
+      beforeComplete: function(sequelize) {
+        this.sequelize = sequelize
+      }.bind(this),
+      onComplete: done
     })
     })
+  })
 
 
-    describe('setAssociation', function() {
-      it('clears the association if null is passed', function(done) {
-        var User = this.sequelize.define('User', { username: Sequelize.STRING })
-          , Task = this.sequelize.define('Task', { title: Sequelize.STRING })
+  describe('setAssociation', function() {
+    it('clears the association if null is passed', function(done) {
+      var User = this.sequelize.define('User', { username: Sequelize.STRING })
+        , Task = this.sequelize.define('Task', { title: Sequelize.STRING })
 
 
-        Task.belongsTo(User)
+      Task.belongsTo(User)
 
 
-        this.sequelize.sync({ force: true }).success(function() {
-          User.create({ username: 'foo' }).success(function(user) {
-            Task.create({ title: 'task' }).success(function(task) {
-              task.setUser(user).success(function() {
-                task.getUser().success(function(user) {
-                  expect(user).not.toEqual(null)
+      this.sequelize.sync({ force: true }).success(function() {
+        User.create({ username: 'foo' }).success(function(user) {
+          Task.create({ title: 'task' }).success(function(task) {
+            task.setUser(user).success(function() {
+              task.getUser().success(function(user) {
+                expect(user).not.toEqual(null)
 
 
-                  task.setUser(null).success(function() {
-                    task.getUser().success(function(user) {
-                      expect(user).toEqual(null)
-                      done()
-                    })
+                task.setUser(null).success(function() {
+                  task.getUser().success(function(user) {
+                    expect(user).toEqual(null)
+                    done()
                   })
                   })
-
                 })
                 })
+
               })
               })
             })
             })
           })
           })

spec/associations/has-one.spec.js

@@ -2,46 +2,44 @@ if (typeof require === 'function') {
   const buster    = require("buster")
   const buster    = require("buster")
       , Sequelize = require("../../index")
       , Sequelize = require("../../index")
       , Helpers   = require('../buster-helpers')
       , Helpers   = require('../buster-helpers')
-      , dialects  = Helpers.getSupportedDialects()
+      , dialect   = Helpers.getTestDialect()
 }
 }
 
 
 buster.spec.expose()
 buster.spec.expose()
 buster.testRunner.timeout = 500
 buster.testRunner.timeout = 500
 
 
-dialects.forEach(function(dialect) {
-  describe('HasOne@' + dialect, function() {
-    before(function(done) {
-      var self = this
+describe("[" + dialect.toUpperCase() + "] HasOne", function() {
+  before(function(done) {
+    var self = this
 
 
-      Helpers.initTests({
-        dialect: dialect,
-        beforeComplete: function(sequelize) { self.sequelize = sequelize },
-        onComplete: done
-      })
+    Helpers.initTests({
+      dialect: dialect,
+      beforeComplete: function(sequelize) { self.sequelize = sequelize },
+      onComplete: done
     })
     })
+  })
 
 
-    describe('setAssociation', function() {
-      it('clears the association if null is passed', function(done) {
-        var User = this.sequelize.define('User', { username: Sequelize.STRING })
-          , Task = this.sequelize.define('Task', { title: Sequelize.STRING })
-
-        User.hasOne(Task)
-
-        this.sequelize.sync({ force: true }).success(function() {
-          User.create({ username: 'foo' }).success(function(user) {
-            Task.create({ title: 'task' }).success(function(task) {
-              user.setTask(task).success(function() {
-                user.getTask().success(function(task) {
-                  expect(task).not.toEqual(null)
-
-                  user.setTask(null).success(function() {
-                    user.getTask().success(function(task) {
-                      expect(task).toEqual(null)
-                      done()
-                    })
-                  })
+  describe('setAssociation', function() {
+    it('clears the association if null is passed', function(done) {
+      var User = this.sequelize.define('User', { username: Sequelize.STRING })
+        , Task = this.sequelize.define('Task', { title: Sequelize.STRING })
+
+      User.hasOne(Task)
 
 
+      this.sequelize.sync({ force: true }).success(function() {
+        User.create({ username: 'foo' }).success(function(user) {
+          Task.create({ title: 'task' }).success(function(task) {
+            user.setTask(task).success(function() {
+              user.getTask().success(function(task) {
+                expect(task).not.toEqual(null)
+
+                user.setTask(null).success(function() {
+                  user.getTask().success(function(task) {
+                    expect(task).toEqual(null)
+                    done()
+                  })
                 })
                 })
+
               })
               })
             })
             })
           })
           })

spec/associations/mixin.spec.js

@@ -2,33 +2,31 @@ if (typeof require === 'function') {
   const buster    = require("buster")
   const buster    = require("buster")
       , Helpers   = require('../buster-helpers')
       , Helpers   = require('../buster-helpers')
       , Sequelize = require('../../index')
       , Sequelize = require('../../index')
-      , dialects  = Helpers.getSupportedDialects()
+      , dialect   = Helpers.getTestDialect()
 }
 }
 
 
 buster.spec.expose()
 buster.spec.expose()
 
 
-dialects.forEach(function(dialect) {
-  describe('Mixin@' + dialect, function() {
-    before(function(done) {
-      Helpers.initTests({
-        dialect: dialect,
-        beforeComplete: function(sequelize) {
-          this.sequelize = sequelize
-        }.bind(this),
-        onComplete: done
-      })
+describe("[" + dialect.toUpperCase() + "] Mixin", function() {
+  before(function(done) {
+    Helpers.initTests({
+      dialect: dialect,
+      beforeComplete: function(sequelize) {
+        this.sequelize = sequelize
+      }.bind(this),
+      onComplete: done
     })
     })
+  })
 
 
-    describe('getAssociation', function() {
-      it('returns the respective part of the association for 1:1 associations', function() {
-        var User = this.sequelize.define('User', {})
-        var Task = this.sequelize.define('Task', {})
+  describe('getAssociation', function() {
+    it('returns the respective part of the association for 1:1 associations', function() {
+      var User = this.sequelize.define('User', {})
+      var Task = this.sequelize.define('Task', {})
 
 
-        User.hasOne(Task)
-        Task.belongsTo(User)
+      User.hasOne(Task)
+      Task.belongsTo(User)
 
 
-        expect(User.getAssociation(Task).target).toEqual(Task)
-      })
+      expect(User.getAssociation(Task).target).toEqual(Task)
     })
     })
   })
   })
 })
 })

spec/dao.spec.js

 if(typeof require === 'function') {
 if(typeof require === 'function') {
-  const buster   = require("buster")
-      , dialects = ['sqlite', 'mysql', 'postgres']
-      , Helpers  = require('./buster-helpers')
+  const buster  = require("buster")
+      , Helpers = require('./buster-helpers')
+      , dialect = Helpers.getTestDialect()
 }
 }
 
 
 buster.spec.expose()
 buster.spec.expose()
 
 
-dialects.forEach(function(dialect) {
-  describe('DAO@' + dialect, function() {
-    before(function(done) {
-      var self = this
+describe("[" + dialect.toUpperCase() + "] DAO", function() {
+  before(function(done) {
+    var self = this
 
 
-      Helpers.initTests({
-        dialect: dialect,
-        beforeComplete: function(sequelize, DataTypes) {
-          self.sequelize = sequelize
-          self.User      = sequelize.define('User', {
-            username:  { type: DataTypes.STRING },
-            touchedAt: { type: DataTypes.DATE, defaultValue: DataTypes.NOW },
-            aNumber:   { type: DataTypes.INTEGER }
-          })
-        },
-        onComplete: function(sequelize) {
-          self.User.sync({ force: true }).success(done)
-        }
-      })
+    Helpers.initTests({
+      dialect: dialect,
+      beforeComplete: function(sequelize, DataTypes) {
+        self.sequelize = sequelize
+        self.User      = sequelize.define('User', {
+          username:  { type: DataTypes.STRING },
+          touchedAt: { type: DataTypes.DATE, defaultValue: DataTypes.NOW },
+          aNumber:   { type: DataTypes.INTEGER }
+        })
+      },
+      onComplete: function() {
+        self.User.sync({ force: true }).success(done)
+      }
     })
     })
+  })
 
 
-    describe('default values', function() {
-      describe('current date', function() {
-        it('should store a date in touchedAt', function() {
-          var user = this.User.build({ username: 'a user'})
-          expect(user.touchedAt instanceof Date).toBeTrue()
-        })
+  describe('default values', function() {
+    describe('current date', function() {
+      it('should store a date in touchedAt', function() {
+        var user = this.User.build({ username: 'a user'})
+        expect(user.touchedAt instanceof Date).toBeTrue()
+      })
 
 
-        it("should store the current date in touchedAt", function() {
-          this.useFakeTimers().tick(5000)
+      it("should store the current date in touchedAt", function() {
+        this.useFakeTimers().tick(5000)
 
 
-          var user = this.User.build({ username: 'a user'})
-          expect(+user.touchedAt).toBe(5000)
-        })
+        var user = this.User.build({ username: 'a user'})
+        expect(+user.touchedAt).toBe(5000)
       })
       })
     })
     })
+  })
 
 
-    describe('complete', function() {
-      it("gets triggered if an error occurs", function(done) {
-        this.User.find({ where: "asdasdasd" }).complete(function(err, result) {
-          expect(err).toBeDefined()
-          expect(err.message).toBeDefined()
-          done()
-        })
+  describe('complete', function() {
+    it("gets triggered if an error occurs", function(done) {
+      this.User.find({ where: "asdasdasd" }).complete(function(err, result) {
+        expect(err).toBeDefined()
+        expect(err.message).toBeDefined()
+        done()
       })
       })
+    })
 
 
-      it("gets triggered if everything was ok", function(done) {
-        this.User.count().complete(function(err, result) {
-          expect(err).toBeNull()
-          expect(result).toBeDefined()
-          done()
-        })
+    it("gets triggered if everything was ok", function(done) {
+      this.User.count().complete(function(err, result) {
+        expect(err).toBeNull()
+        expect(result).toBeDefined()
+        done()
       })
       })
     })
     })
+  })
 
 
-    describe('save', function() {
-      it('takes zero into account', function(done) {
-        this.User.build({ aNumber: 0 }).save([ 'aNumber' ]).success(function(user) {
-          expect(user.aNumber).toEqual(0)
-          done()
-        })
+  describe('save', function() {
+    it('takes zero into account', function(done) {
+      this.User.build({ aNumber: 0 }).save([ 'aNumber' ]).success(function(user) {
+        expect(user.aNumber).toEqual(0)
+        done()
       })
       })
     })
     })
+  })
 
 
-    describe('toJSON', function toJSON() {
-      before(function(done) {
-        this.User = this.sequelize.define('UserWithUsernameAndAgeAndIsAdmin', {
-          username: Helpers.Sequelize.STRING,
-          age:      Helpers.Sequelize.INTEGER,
-          isAdmin:  Helpers.Sequelize.BOOLEAN
-        }, {
-          timestamps: false,
-          logging: true
-        })
-
-        this.User.sync({ force: true }).success(done)
+  describe('toJSON', function toJSON() {
+    before(function(done) {
+      this.User = this.sequelize.define('UserWithUsernameAndAgeAndIsAdmin', {
+        username: Helpers.Sequelize.STRING,
+        age:      Helpers.Sequelize.INTEGER,
+        isAdmin:  Helpers.Sequelize.BOOLEAN
+      }, {
+        timestamps: false,
+        logging: true
       })
       })
 
 
-      it('returns an object containing all values', function() {
-        var user = this.User.build({ username: 'test.user', age: 99, isAdmin: true })
-        expect(user.toJSON()).toEqual({ username: 'test.user', age: 99, isAdmin: true, id: null })
-      })
+      this.User.sync({ force: true }).success(done)
+    })
 
 
-      it('returns a response that can be stringified', function() {
-        var user = this.User.build({ username: 'test.user', age: 99, isAdmin: true })
-        expect(JSON.stringify(user)).toEqual('{"username":"test.user","age":99,"isAdmin":true,"id":null}')
-      })
+    it('returns an object containing all values', function() {
+      var user = this.User.build({ username: 'test.user', age: 99, isAdmin: true })
+      expect(user.toJSON()).toEqual({ username: 'test.user', age: 99, isAdmin: true, id: null })
+    })
 
 
-      it('returns a response that can be stringified and then parsed', function() {
-        var user = this.User.build({ username: 'test.user', age: 99, isAdmin: true })
-        expect(JSON.parse(JSON.stringify(user))).toEqual({ username: 'test.user', age: 99, isAdmin: true, id: null })
-      })
+    it('returns a response that can be stringified', function() {
+      var user = this.User.build({ username: 'test.user', age: 99, isAdmin: true })
+      expect(JSON.stringify(user)).toEqual('{"username":"test.user","age":99,"isAdmin":true,"id":null}')
+    })
+
+    it('returns a response that can be stringified and then parsed', function() {
+      var user = this.User.build({ username: 'test.user', age: 99, isAdmin: true })
+      expect(JSON.parse(JSON.stringify(user))).toEqual({ username: 'test.user', age: 99, isAdmin: true, id: null })
     })
     })
   })
   })
 })
 })

spec/query-chainer.spec.js

@@ -2,13 +2,14 @@ if(typeof require === 'function') {
   const buster             = require("buster")
   const buster             = require("buster")
       , QueryChainer       = require("../lib/query-chainer")
       , QueryChainer       = require("../lib/query-chainer")
       , CustomEventEmitter = require("../lib/emitters/custom-event-emitter")
       , CustomEventEmitter = require("../lib/emitters/custom-event-emitter")
+      , Helpers            = require('./buster-helpers')
+      , dialect            = Helpers.getTestDialect()
 }
 }
 
 
 buster.spec.expose()
 buster.spec.expose()
 buster.testRunner.timeout = 1000
 buster.testRunner.timeout = 1000
 
 
-
-describe('QueryChainer', function() {
+describe("[" + dialect.toUpperCase() + "] QueryChainer", function() {
   before(function() {
   before(function() {
     this.queryChainer = new QueryChainer()
     this.queryChainer = new QueryChainer()
   })
   })

spec/sequelize.spec.js

 if(typeof require === 'function') {
 if(typeof require === 'function') {
-  const buster    = require("buster")
-      , Helpers   = require('./buster-helpers')
+  const buster  = require("buster")
+      , Helpers = require('./buster-helpers')
+      , dialect = Helpers.getTestDialect()
+
 }
 }
 
 
 buster.spec.expose()
 buster.spec.expose()
 
 
-describe('Sequelize', function() {
+describe("[" + dialect.toUpperCase() + "] Sequelize", function() {
   before(function(done) {
   before(function(done) {
     Helpers.initTests({
     Helpers.initTests({
       beforeComplete: function(sequelize) { this.sequelize = sequelize }.bind(this),
       beforeComplete: function(sequelize) { this.sequelize = sequelize }.bind(this),
@@ -44,7 +46,7 @@ describe('Sequelize', function() {
       })
       })
     })
     })
 
 
-    it('executes a query if only the sql is passed', function(done) {
+    it('//executes a query if only the sql is passed', function(done) {
       this.sequelize.query(this.insertQuery).success(function(result) {
       this.sequelize.query(this.insertQuery).success(function(result) {
         expect(result).toBeNull()
         expect(result).toBeNull()
         done()
         done()

spec/sqlite/dao.spec.js

 if(typeof require === 'function') {
 if(typeof require === 'function') {
   const buster  = require("buster")
   const buster  = require("buster")
       , Helpers = require('../buster-helpers')
       , Helpers = require('../buster-helpers')
+      , dialect = Helpers.getTestDialect()
 }
 }
 
 
 buster.spec.expose()
 buster.spec.expose()
 
 
-describe('DAO@sqlite', function() {
-  before(function(done) {
-    var self = this
+if (dialect === 'sqlite') {
+  describe('[SQLITE] DAO', function() {
+    before(function(done) {
+      var self = this
 
 
-    Helpers.initTests({
-      dialect: 'sqlite',
-      beforeComplete: function(sequelize, DataTypes) {
-        self.sequelize = sequelize
+      Helpers.initTests({
+        dialect: 'sqlite',
+        beforeComplete: function(sequelize, DataTypes) {
+          self.sequelize = sequelize
 
 
-        self.User = sequelize.define('User', {
-          username: DataTypes.STRING
-        })
-      },
-      onComplete: function(sequelize) {
-        self.User.sync({ force: true }).success(done)
-      }
+          self.User = sequelize.define('User', {
+            username: DataTypes.STRING
+          })
+        },
+        onComplete: function() {
+          self.User.sync({ force: true }).success(done)
+        }
+      })
     })
     })
-  })
 
 
-  describe('findAll', function() {
-    it("handles dates correctly", function(done) {
-      var self = this
+    describe('findAll', function() {
+      it("handles dates correctly", function(done) {
+        var self = this
 
 
-      this.User
-        .create({ username: 'user', createdAt: new Date(2011, 04, 04) })
-        .success(function(oldUser) {
-          self.User
-            .create({ username: 'new user' })
-            .success(function(newUser) {
-              self.User.findAll({
-                where: ['createdAt > ?', new Date(2012, 01, 01)]
-              }).success(function(users) {
-                expect(users.length).toEqual(1)
-                done()
+        this.User
+          .create({ username: 'user', createdAt: new Date(2011, 04, 04) })
+          .success(function(oldUser) {
+            self.User
+              .create({ username: 'new user' })
+              .success(function(newUser) {
+                self.User.findAll({
+                  where: ['createdAt > ?', new Date(2012, 01, 01)]
+                }).success(function(users) {
+                  expect(users.length).toEqual(1)
+                  done()
+                })
               })
               })
-            })
-        })
-        .error(function(err) {
-          console.log(err)
-        })
+          })
+          .error(function(err) {
+            console.log(err)
+          })
+      })
     })
     })
   })
   })
-})
+}