Set updatedAt timestamp when validations is true in bulkUpdate. Closes #1962

changelog.md

@@ -11,6 +11,7 @@ Notice: All 1.7.x changes are present in 2.0.x aswell
 - [BUG] Fixed problems with transcation parameter being removed / not passed on in associations [#1789](https://github.com/sequelize/sequelize/issues/1789) and [#1968](https://github.com/sequelize/sequelize/issues/1968)
 - [BUG] Fixed problems with transcation parameter being removed / not passed on in associations [#1789](https://github.com/sequelize/sequelize/issues/1789) and [#1968](https://github.com/sequelize/sequelize/issues/1968)
 - [BUG] Fix problem with minConnections. [#2048](https://github.com/sequelize/sequelize/issues/2048)
 - [BUG] Fix problem with minConnections. [#2048](https://github.com/sequelize/sequelize/issues/2048)
 - [BUG] Fix default scope being overwritten [#2087](https://github.com/sequelize/sequelize/issues/2087)
 - [BUG] Fix default scope being overwritten [#2087](https://github.com/sequelize/sequelize/issues/2087)
+- [BUG] Fixed updatedAt timestamp not being set in bulk create when validate = true. [#1962](https://github.com/sequelize/sequelize/issues/1962)
 - [INTERNALS] Replaced lingo with inflection
 - [INTERNALS] Replaced lingo with inflection
 - [INTERNALS] Removed underscore.string dependency and moved a couple of helper functions from `Utils._` to `Utils` 
 - [INTERNALS] Removed underscore.string dependency and moved a couple of helper functions from `Utils._` to `Utils` 
 - [INTERNALS] Update dependencies
 - [INTERNALS] Update dependencies

lib/model.js

@@ -1376,6 +1376,7 @@ module.exports = (function() {
       // Validate
       // Validate
       if (options.validate) {
       if (options.validate) {
         var build = self.build(attrValueHash);
         var build = self.build(attrValueHash);
+        build.set(self._timestampAttributes.updatedAt, attrValueHash[self._timestampAttributes.updatedAt], { raw: true });
 
 
         // We want to skip validations for all other fields
         // We want to skip validations for all other fields
         var skippedFields = Utils._.difference(Object.keys(self.attributes), Object.keys(attrValueHash));
         var skippedFields = Utils._.difference(Object.keys(self.attributes), Object.keys(attrValueHash));

test/dao-factory.test.js

@@ -860,30 +860,38 @@ describe(Support.getTestDialectTeaser("DAOFactory"), function () {
       })
       })
     })
     })
 
 
-    it('sets updatedAt to the current timestamp', function(done) {
-      var self = this
-        , data = [{ username: 'Peter', secretValue: '42' },
+    it('sets updatedAt to the current timestamp', function() {
+      var data = [{ username: 'Peter', secretValue: '42' },
                   { username: 'Paul',  secretValue: '42' },
                   { username: 'Paul',  secretValue: '42' },
-                  { username: 'Bob',   secretValue: '43' }]
+                  { username: 'Bob',   secretValue: '43' }];
 
 
-      this.User.bulkCreate(data).success(function() {
-        self.User.update({username: 'Bill'}, {secretValue: '42'}).done(function(err) {
-          expect(err).not.to.be.ok
-          self.User.findAll({order: 'id'}).success(function(users) {
-            expect(users.length).to.equal(3)
+      this.clock = sinon.useFakeTimers();
 
 
-            expect(users[0].username).to.equal("Bill")
-            expect(users[1].username).to.equal("Bill")
-            expect(users[2].username).to.equal("Bob")
+      return this.User.bulkCreate(data).bind(this).then(function() {
+        return this.User.findAll({order: 'id'});
+      }).then(function (users) {
+        this.updatedAt = users[0].updatedAt;
 
 
-            expect(parseInt(+users[0].updatedAt/5000, 10)).to.be.closeTo(parseInt(+new Date()/5000, 10), 1)
-            expect(parseInt(+users[1].updatedAt/5000, 10)).to.be.closeTo(parseInt(+new Date()/5000, 10), 1)
+        expect(this.updatedAt).to.be.ok;
+        expect(this.updatedAt).to.equalTime(users[2].updatedAt); // All users should have the same updatedAt
 
 
-            done()
-          })
-        })
-      })
-    })
+        // Pass the time so we can actually see a change
+        this.clock.tick(1000);
+
+        return this.User.update({username: 'Bill'}, {secretValue: '42'});
+      }).then(function () {
+        return this.User.findAll({order: 'id'});
+      }).then(function (users) {
+        expect(users[0].username).to.equal("Bill");
+        expect(users[1].username).to.equal("Bill");
+        expect(users[2].username).to.equal("Bob");
+
+        expect(users[0].updatedAt).to.be.afterTime(this.updatedAt);
+        expect(users[2].updatedAt).to.equalTime(this.updatedAt);
+
+        this.clock.restore();
+      });
+    });
 
 
     it('returns the number of affected rows', function(_done) {
     it('returns the number of affected rows', function(_done) {
      var self = this
      var self = this