Update changelog

Jan Aagaard Meier
Commit ce8a63e2 authored Jun 24, 2013 by Jan Aagaard Meier
Showing with 4 additions and 3 deletions
changelog.md
lib/dialects/mysql/query-generator.js
lib/dialects/sqlite/query-generator.js
--- a/changelog.md
+++ b/changelog.md
@@ -30,11 +30,12 @@
 - [FEATURE] `findOrCreate` now returns an additional flag (`created`), that is true if a model was created, and false if it was found [#648](https://github.com/sequelize/sequelize/pull/648). janmeier
 - [FEATURE] Field and table comments for MySQL and PG. [#523](https://github.com/sequelize/sequelize/pull/523). MySQL by iamjochen. PG by janmeier
 - [FEATURE] BigInts can now be used for autoincrement/serial columns. [#673](https://github.com/sequelize/sequelize/pull/673). thanks to sevastos
- [REFACTORING] hasMany now uses a single SQL statement when creating and destroying associations, instead of removing each association seperately [690](https://github.com/sequelize/sequelize/pull/690). Inspired by [#104](https://github.com/sequelize/sequelize/issues/104). janmeier
 - [FEATURE] Use moment for better postgres timestamp strings. [#710](https://github.com/sequelize/sequelize/pull/710). Thanks to seth-admittedly
 - [FEATURE] Keep milliseconds in timestamps for postgres. [#712](https://github.com/sequelize/sequelize/pull/712). Thanks to seth-admittedly
 - [FEATURE] You can now set lingo's language through Sequelize. [#713](https://github.com/sequelize/sequelize/pull/713). Thanks to durango
 - [FEATURE] Added a `findAndCountAll`, useful for pagination. [#533](https://github.com/sequelize/sequelize/pull/533). Thanks to iamjochen
+- [REFACTORING] hasMany now uses a single SQL statement when creating and destroying associations, instead of removing each association seperately [690](https://github.com/sequelize/sequelize/pull/690). Inspired by [#104](https://github.com/sequelize/sequelize/issues/104). janmeier
+- [REFACTORING] Consistent handling of offset across dialects. Offset is now always applied, and limit is set to max table size of not limit is given [#725](https://github.com/sequelize/sequelize/pull/725). janmeier
 # v1.6.0 #
 - [DEPENDENCIES] upgrade mysql to alpha7. You *MUST* use this version or newer for DATETIMEs to work

--- a/lib/dialects/mysql/query-generator.js
+++ b/lib/dialects/mysql/query-generator.js
@@ -219,7 +219,7 @@ module.exports = (function() {
      if (options.offset && !options.limit) {
        /*
-         * If not limit is defined, our best bet is to use the max number of rows in a table. From the MySQL docs:
+         * If no limit is defined, our best bet is to use the max number of rows in a table. From the MySQL docs:
         * There is a limit of 2^32 (~4.295E+09) rows in a MyISAM table. If you build MySQL with the --with-big-tables option, 
         * the row limitation is increased to (2^32)^2 (1.844E+19) rows.
         */

--- a/lib/dialects/sqlite/query-generator.js
+++ b/lib/dialects/sqlite/query-generator.js
@@ -190,7 +190,7 @@ module.exports = (function() {
      if (options.offset && !options.limit) {
        /*
-         * If not limit is defined, our best bet is to use the max number of rows in a table. From the SQLite docs:
+         * If no limit is defined, our best bet is to use the max number of rows in a table. From the SQLite docs:
         * A 140 terabytes database can hold no more than approximately 1e+13 rows
         */
        query += " LIMIT " + options.offset + ", " + 10000000000000;