fix(querying): swap startWith and endsWith operators (#10753)

docs/querying.md

@@ -162,8 +162,8 @@ const Op = Sequelize.Op
 [Op.notLike]: '%hat'       // NOT LIKE '%hat'
 [Op.notLike]: '%hat'       // NOT LIKE '%hat'
 [Op.iLike]: '%hat'         // ILIKE '%hat' (case insensitive) (PG only)
 [Op.iLike]: '%hat'         // ILIKE '%hat' (case insensitive) (PG only)
 [Op.notILike]: '%hat'      // NOT ILIKE '%hat'  (PG only)
 [Op.notILike]: '%hat'      // NOT ILIKE '%hat'  (PG only)
-[Op.startsWith]: 'hat'     // LIKE '%hat'
-[Op.endsWith]: 'hat'       // LIKE 'hat%'
+[Op.startsWith]: 'hat'     // LIKE 'hat%'
+[Op.endsWith]: 'hat'       // LIKE '%hat'
 [Op.substring]: 'hat'      // LIKE '%hat%'
 [Op.substring]: 'hat'      // LIKE '%hat%'
 [Op.regexp]: '^[h|a|t]'    // REGEXP/~ '^[h|a|t]' (MySQL/PG only)
 [Op.regexp]: '^[h|a|t]'    // REGEXP/~ '^[h|a|t]' (MySQL/PG only)
 [Op.notRegexp]: '^[h|a|t]' // NOT REGEXP/!~ '^[h|a|t]' (MySQL/PG only)
 [Op.notRegexp]: '^[h|a|t]' // NOT REGEXP/!~ '^[h|a|t]' (MySQL/PG only)

lib/dialects/abstract/query-generator.js

@@ -2385,10 +2385,10 @@ class QueryGenerator {
         return this._joinKeyValue(key, value.map(identifier => this.quoteIdentifier(identifier)).join('.'), comparator, options.prefix);
         return this._joinKeyValue(key, value.map(identifier => this.quoteIdentifier(identifier)).join('.'), comparator, options.prefix);
       case Op.startsWith:
       case Op.startsWith:
         comparator = this.OperatorMap[Op.like];
         comparator = this.OperatorMap[Op.like];
-        return this._joinKeyValue(key, this.escape(`%${value}`), comparator, options.prefix);
+        return this._joinKeyValue(key, this.escape(`${value}%`), comparator, options.prefix);
       case Op.endsWith:
       case Op.endsWith:
         comparator = this.OperatorMap[Op.like];
         comparator = this.OperatorMap[Op.like];
-        return this._joinKeyValue(key, this.escape(`${value}%`), comparator, options.prefix);
+        return this._joinKeyValue(key, this.escape(`%${value}`), comparator, options.prefix);
       case Op.substring:
       case Op.substring:
         comparator = this.OperatorMap[Op.like];
         comparator = this.OperatorMap[Op.like];
         return this._joinKeyValue(key, this.escape(`%${value}%`), comparator, options.prefix);
         return this._joinKeyValue(key, this.escape(`%${value}%`), comparator, options.prefix);

test/unit/sql/where.test.js

@@ -438,8 +438,8 @@ describe(Support.getTestDialectTeaser('SQL'), () => {
       testsql('username', {
       testsql('username', {
         [Op.startsWith]: 'swagger'
         [Op.startsWith]: 'swagger'
       }, {
       }, {
-        default: "[username] LIKE '%swagger'",
-        mssql: "[username] LIKE N'%swagger'"
+        default: "[username] LIKE 'swagger%'",
+        mssql: "[username] LIKE N'swagger%'"
       });
       });
     });
     });
 
 
@@ -447,8 +447,8 @@ describe(Support.getTestDialectTeaser('SQL'), () => {
       testsql('username', {
       testsql('username', {
         [Op.endsWith]: 'swagger'
         [Op.endsWith]: 'swagger'
       }, {
       }, {
-        default: "[username] LIKE 'swagger%'",
-        mssql: "[username] LIKE N'swagger%'"
+        default: "[username] LIKE '%swagger'",
+        mssql: "[username] LIKE N'%swagger'"
       });
       });
     });
     });