Merge pull request #5226 from sushantdhiman/fix-5092

Fix 5092

changelog.md

-# FUTURE
+# Future
 - [ADDED] Support silent: true in bulk update [#5200](https://github.com/sequelize/sequelize/issues/5200)
 - [ADDED] Support silent: true in bulk update [#5200](https://github.com/sequelize/sequelize/issues/5200)
+- [FIXED] Postgres destroy with `where` fails on JSONB data [#5092](https://github.com/sequelize/sequelize/issues/5092)
 
 
 # 3.17.3
 # 3.17.3
 - [FIXED] Regression with array values from security fix in 3.17.2
 - [FIXED] Regression with array values from security fix in 3.17.2

lib/dialects/postgres/query-generator.js

@@ -375,7 +375,7 @@ var QueryGenerator = {
 
 
     var replacements = {
     var replacements = {
       table: this.quoteIdentifiers(tableName),
       table: this.quoteIdentifiers(tableName),
-      where: this.getWhereConditions(where),
+      where: this.getWhereConditions(where, null, model, options),
       limit: !!options.limit ? ' LIMIT ' + this.escape(options.limit) : '',
       limit: !!options.limit ? ' LIMIT ' + this.escape(options.limit) : '',
       primaryKeys: primaryKeys[tableName].length > 1 ? '(' + pks + ')' : pks,
       primaryKeys: primaryKeys[tableName].length > 1 ? '(' + pks + ')' : pks,
       primaryKeysSelection: pks
       primaryKeysSelection: pks

test/integration/model/json.test.js

@@ -310,6 +310,53 @@ describe(Support.getTestDialectTeaser('Model'), function() {
           });
           });
         });
         });
       });
       });
+
+      it('should be possible to destroy with where', function () {
+        var conditionSearch = {
+          where: {
+            data: {
+              employment : 'Hacker'
+            }
+          }
+        };
+
+        return Promise.join(
+          this.Event.create({
+            data: {
+              name: {
+                first: 'Elliot',
+                last: 'Alderson'
+              },
+              employment: 'Hacker'
+            }
+          }),
+          this.Event.create({
+            data: {
+              name: {
+                first: 'Christian',
+                last: 'Slater'
+              },
+              employment: 'Hacker'
+            }
+          }),
+          this.Event.create({
+            data: {
+              name: {
+                first: ' Tyrell',
+                last: 'Wellick'
+              },
+              employment: 'CTO'
+            }
+          })
+        ).bind(this).then(function () {
+            return expect(this.Event.findAll(conditionSearch)).to.eventually.have.length(2);
+          }).then(function() {
+            return this.Event.destroy(conditionSearch);
+          }).then(function(){
+            return expect(this.Event.findAll(conditionSearch)).to.eventually.have.length(0);
+          });
+      });
+
     });
     });
   }
   }
 });
 });