Merge pull request #297 from kbackowski/fix_empty_in_condition

Fixed IN statements to generate valid sql when condition array is empty

lib/dialects/mysql/query-generator.js

@@ -340,7 +340,7 @@ module.exports = (function() {
 
 
         if (Array.isArray(value)) {
         if (Array.isArray(value)) {
           // is value an array?
           // is value an array?
-
+          if(value.length == 0) { value = [null] }
           _value = "(" + value.map(function(subValue) {
           _value = "(" + value.map(function(subValue) {
             return Utils.escape(subValue);
             return Utils.escape(subValue);
           }).join(',') + ")"
           }).join(',') + ")"

lib/dialects/postgres/query-generator.js

@@ -407,6 +407,7 @@ module.exports = (function() {
           , _value = null
           , _value = null
 
 
         if(Array.isArray(value)) {
         if(Array.isArray(value)) {
+          if(value.length == 0) { value = [null] }
           _value = "(" + value.map(function(subValue) {
           _value = "(" + value.map(function(subValue) {
             return pgEscape(subValue);
             return pgEscape(subValue);
           }).join(',') + ")"
           }).join(',') + ")"

spec-jasmine/mysql/query-generator.spec.js

@@ -207,6 +207,10 @@ describe('QueryGenerator', function() {
       {
       {
         arguments: [{ id: [1,2,3] }],
         arguments: [{ id: [1,2,3] }],
         expectation: "`id` IN (1,2,3)"
         expectation: "`id` IN (1,2,3)"
+      },
+      {
+        arguments: [{ id: [] }],
+        expectation: "`id` IN (NULL)"
       }
       }
     ]
     ]
   }
   }

spec-jasmine/postgres/query-generator.spec.js

@@ -237,6 +237,10 @@ describe('QueryGenerator', function() {
       {
       {
         arguments: [{ id: [1,2,3] }],
         arguments: [{ id: [1,2,3] }],
         expectation: "\"id\" IN (1,2,3)"
         expectation: "\"id\" IN (1,2,3)"
+      },
+      {
+        arguments: [{ id: [] }],
+        expectation: "\"id\" IN (NULL)"
       }
       }
     ]
     ]
   }
   }