perf: fix memory leak due to instance reference by isImmutable (#9973)

lib/instance-validator.js

@@ -7,7 +7,6 @@ const Promise = require('./promise');
 const DataTypes = require('./data-types');
 const DataTypes = require('./data-types');
 const BelongsTo = require('./associations/belongs-to');
 const BelongsTo = require('./associations/belongs-to');
 const validator = require('./utils/validator-extras').validator;
 const validator = require('./utils/validator-extras').validator;
-const extendModelValidations = require('./utils/validator-extras').extendModelValidations;
 
 
 /**
 /**
  * Instance Validator.
  * Instance Validator.
@@ -54,8 +53,6 @@ class InstanceValidator {
      * @private
      * @private
      */
      */
     this.inProgress = false;
     this.inProgress = false;
-
-    extendModelValidations(modelInstance);
   }
   }
 
 
   /**
   /**
@@ -310,7 +307,7 @@ class InstanceValidator {
 
 
     if (!Array.isArray(validatorArgs)) {
     if (!Array.isArray(validatorArgs)) {
       if (validatorType === 'isImmutable') {
       if (validatorType === 'isImmutable') {
-        validatorArgs = [validatorArgs, field];
+        validatorArgs = [validatorArgs, field, this.modelInstance];
       } else if (isLocalizedValidator || validatorType === 'isIP') {
       } else if (isLocalizedValidator || validatorType === 'isIP') {
         validatorArgs = [];
         validatorArgs = [];
       } else {
       } else {

lib/utils/validator-extras.js

@@ -64,19 +64,12 @@ const extensions = {
 };
 };
 exports.extensions = extensions;
 exports.extensions = extensions;
 
 
-function extendModelValidations(modelInstance) {
-  const extensions = {
-    isImmutable(str, param, field) {
-      return modelInstance.isNewRecord || modelInstance.dataValues[field] === modelInstance._previousDataValues[field];
-    }
-  };
-
-  _.forEach(extensions, (extend, key) => {
-    validator[key] = extend;
-  });
-}
-exports.extendModelValidations = extendModelValidations;
+/** Instance based validators */
+validator.isImmutable = function(value, validatorArgs, field, modelInstance) {
+  return modelInstance.isNewRecord || modelInstance.dataValues[field] === modelInstance._previousDataValues[field];
+};
 
 
+/** Extra validators */
 validator.notNull = function(val) {
 validator.notNull = function(val) {
   return ![null, undefined].includes(val);
   return ![null, undefined].includes(val);
 };
 };