public / sequelize

In generating the bulk insert query, the serials are stored in an
array. This array can potentially be up to size N, which is the number
of rows to be created.

When generating the tuples at a later stage, we walk through the
records one-by-one - O(N) iterations. However, in a single iteration,
we were performing a lookup in the serials array (indexOf costs O(N)),
leading to a O(N^2) runtime and poor performance for large number of
records inserted.

This patch converts the serials array into an object map instead, so
lookups cost O(1) time.

This fixes #6606

https://greenkeeper.io/

* Expose OptimisticLockError on Sequelize object (#6637)

* Future changelog entry

…chriso/validator.js/issues/618)

Small typo

* performance this Array.concat with for loop/push

for loop/push is much faster than Array.concat.
For the largest/ugliest queries, this can get
called hundreds of thousands of times, so the
performance difference does matter.

* add message to changelog.md

https://greenkeeper.io/

* Added unique indexes to rawAttributes

* Add changelog entry

* Added integration test to cover composite unique keys, review fixes

* Fixes failing tests

* Add quotes around column names for unique constraints in sqlite (fixes #4407)

* Changelog linked to issue

* fix error when connect to Postgres 8.2.0

* Update sequelize.md

* separating version check for clean code

* changelog: properly state oids for postgres

* Adds JSON support for sqlite

* Add JSON support to sqlite query-generator

* add integration test for sqlite json

* add unit test for sqlite json

* fix inaccurate test for json from postgres

* Fix failing test spec in postgres

* Change accroding to review

- Change MySqlQueryGenerator to AbstractQueryGenerator (sqlite)
- Move parseConditionObject method to the AbstractQueryGenerator (sqlite, postgres)
- Remove unnecessary module require
- Remove extra lines

* Fix failing test with sequelize static reference

* Add JSONB type alias to sqlite data types

* Update changelog.md

* Update jsdoc for JSON datatype

* Updates from PR feedback

- Convert es5 syntax to es6 for sqlite query-generator

* Fix parenthesis with single parameter

* Fix deleteQuery condition with JSON field

* Update integration/data-types.test.js

* Add JSON injection preventation code for sqlite

- Add checkValidJsonStatement method to sqlite query-generator
- Add injection tests for sqlite

* Update sqlite JSON query-generator

* Move common json DAO tests to abstract/dao.test.js

- Add support for json property accessors (sqlite, postgres)

* Fix wrong indentation in abstract/query-generator.js

* Update query-generator.js to use common json method

* Fix inconsistent postgres cast syntax

* Update JSON test specs

- Add injection test for postgres/query-generators.js
- Replace default sql test expectation with specific dialect (postgres)
- Update expectsql from test/support.js to throw error when no default expectation

* Fix failing postgres test with cast

* Fix postgres casting syntax

* Fix failing test for postgres

* Revert indentation of postgres query-generator

* Cleanup unnecessarily added code

update jsdoc of jsonPathExtractionQuery to match the exact function arguments

* Move integration/dialects/abstract/dao.test.js to integration/json.test.js

* Rewrite unit tests for json query-generator in unit/sql/json.test.js

* Capitalize AND operator while generating json query via condition object

* Fix failed tests

Spelling correction.

* Fixes setAssociation with scope

* Fixes style

* Refactored support for ORDER BY clause so SQL injection is not possible.

* Adds sublime text files to gitignore.
Modified changelog to accurately represent changes to the order property.
Fixed lint issues.

* Added rejection with error where Order must be type of Array or instance of sequelize literal.

* Removed support for options.order accepting strings.
@TODO Look into plain objects with property raw
@TODO Update documentation and tests

* Removed all direct lodash and replaced them with Utils.
ie. `_.isPlainObject` is now `Utils._.isPlainObject`
find: `(?s)(?<!Utils\.)_\.`
replace : `Utils._.`

* Updates documentation for findAll order.

* Added removeTicks to addTicks in quoteIdentifier for each dialect.

* Added documentation for order by only an array.

* Added breaking change to changelog and renamed error to be more general.

@TODO: TESTS!

* Fixes bad code when checking if the order is valid.

* Updated unit tests.

* Should incorporate all integration tests.

* Update changelog.md capitalize Sequelize

* Changes everything in query generator to use lodash outside of utils.

* Instead of checking if the order object is an instance of a Utils member we just see if `_.isSequelizeMethod` is truthy.

* Removing escapeId because it is no longer used.

* Instead of removing ticks, we should escape them.

* Instead of removing ticks, we should escape them. (reverted from commit e4dade0a18be85dfaf8f91f1210bc0b5bedcb31a)

* Removes support for `._isSequelizeMethod` because it can be spoofed.  Instead, use instanceof.

* Refactored support for ORDER BY clause so SQL injection is not possible.

* Adds sublime text files to gitignore.
Modified changelog to accurately represent changes to the order property.
Fixed lint issues.

* Added rejection with error where Order must be type of Array or instance of sequelize literal.

* Removed support for options.order accepting strings.
@TODO Look into plain objects with property raw
@TODO Update documentation and tests

* Removed all direct lodash and replaced them with Utils.
ie. `_.isPlainObject` is now `Utils._.isPlainObject`
find: `(?s)(?<!Utils\.)_\.`
replace : `Utils._.`

* Updates documentation for findAll order.

* Added removeTicks to addTicks in quoteIdentifier for each dialect.

* Added documentation for order by only an array.

* Added breaking change to changelog and renamed error to be more general.

@TODO: TESTS!

* Fixes bad code when checking if the order is valid.

* Updated unit tests.

* Should incorporate all integration tests.

* Update changelog.md capitalize Sequelize

* Changes everything in query generator to use lodash outside of utils.

* Instead of checking if the order object is an instance of a Utils member we just see if `_.isSequelizeMethod` is truthy.

* Removing escapeId because it is no longer used.

* Instead of removing ticks, we should escape them.

* Instead of removing ticks, we should escape them. (reverted from commit e4dade0a18be85dfaf8f91f1210bc0b5bedcb31a)

* (docs/docs/associations.md) punctuation fix - added comma

* (docs/docs/associations.md) punctuation fix - added comma

* (docs/docs/associations.md) grammar correction

* Pass options to MSSQL removeColumn queries

* [ci skip] Added changelog entry

* Review fixes - Use Object.assign instead of lodash assign

* Update changelog description

* fix ER_EMPTY_QUERY error on update with virtual fields for master

* fix review

* [ci skip] Changelog for #6356

* Fixes creation of polymorphic belongToMany associations in one step

* Fix test failure for MSSQL

* Fix tests

* Fix `Instance.decrement` precision problems

* [ci skip] Link to issue

* Throw an error when attribute options are not formatted correctly

* remove space

* update changelong

* Tedious debug undefined dialectOptions fix

* Added PR link to changelog

v3: sourceKey feature for hasMany doesn't work if where clause specified in include (#7141) (#7147)

* Initial Commit

* Stops test from removing test/integration/assets/es6project.js

* Fixes impromper syntax when specifying the use of association.sourceIdentifier or left.primaryKeyAttribute for attrLeft. Also includes integration test.

* Updates changelog.

* Adds link to issue in changelog entry.

* Added 'Future' header to changelog entry

* Removed changelog update as requested.

* Updates changelog. Fixes query-generator to properly build queries from hasMany even with an include while respecting a specified sourceKey. Adds an integration test.

* Added back removed whitespace per request.

* Updates test in include altered field name in source key. Fixes were then made to address the test breaking. All tests pass now.

* Adds back removed whitespace.

* MSSQL - Skip isolationLevel query, enable tedious debugging

* Added changelog entry, updated docs

* generic pool update and other fixes

* connection internally removed

* doc entry

* review changes

* pooling changes

* Added getPrimaryKeyConstraint method to drop primarykey constraint before dropping primarykey column

* Added changelog entry, exclude primaryKey constraint for mysql removeColumn method

* Review fixes

* Fixes failing test