test(unit): do not use sinon syntactic sugar returns (#8491)

test/unit/instance-validator.test.js

@@ -87,7 +87,9 @@ describe(Support.getTestDialectTeaser('InstanceValidator'), () => {
 
     it('should run beforeValidate hook but not afterValidate hook when _validate is unsuccessful', () => {
       const failingInstanceValidator = new InstanceValidator(this.User.build());
-      sinon.stub(failingInstanceValidator, '_validate').returns(Promise.reject());
+      sinon.stub(failingInstanceValidator, '_validate', () => {
+        return Promise.reject();
+      });
       const beforeValidate = sinon.spy();
       const afterValidate = sinon.spy();
       this.User.beforeValidate(beforeValidate);
@@ -110,7 +112,9 @@ describe(Support.getTestDialectTeaser('InstanceValidator'), () => {
     describe('validatedFailed hook', () => {
       it('should call validationFailed hook when validation fails', () => {
         const failingInstanceValidator = new InstanceValidator(this.User.build());
-        sinon.stub(failingInstanceValidator, '_validate').returns(Promise.reject());
+        sinon.stub(failingInstanceValidator, '_validate', () => {
+          return Promise.reject();
+        });
         const validationFailedHook = sinon.spy();
         this.User.validationFailed(validationFailedHook);
 
@@ -121,7 +125,9 @@ describe(Support.getTestDialectTeaser('InstanceValidator'), () => {
 
       it('should not replace the validation error in validationFailed hook by default', () => {
         const failingInstanceValidator = new InstanceValidator(this.User.build());
-        sinon.stub(failingInstanceValidator, '_validate').returns(Promise.reject(new SequelizeValidationError()));
+        sinon.stub(failingInstanceValidator, '_validate', () => {
+          return Promise.reject(new SequelizeValidationError());
+        });
         const validationFailedHook = sinon.stub().returns(Promise.resolve());
         this.User.validationFailed(validationFailedHook);
 
@@ -132,7 +138,9 @@ describe(Support.getTestDialectTeaser('InstanceValidator'), () => {
 
       it('should replace the validation error if validationFailed hook creates a new error', () => {
         const failingInstanceValidator = new InstanceValidator(this.User.build());
-        sinon.stub(failingInstanceValidator, '_validate').returns(Promise.reject(new SequelizeValidationError()));
+        sinon.stub(failingInstanceValidator, '_validate', () => {
+          return Promise.reject(new SequelizeValidationError());
+        });
         const validationFailedHook = sinon.stub().throws(new Error('validation failed hook error'));
         this.User.validationFailed(validationFailedHook);
 

test/unit/model/find-create-find.test.js

@@ -52,7 +52,9 @@ describe(Support.getTestDialectTeaser('Model'), () => {
         where = {prop: Math.random().toString()},
         findSpy = this.sinon.stub(Model, 'findOne');
 
-      this.sinon.stub(Model, 'create').returns(Promise.reject(new UniqueConstraintError()));
+      this.sinon.stub(Model, 'create', () => {
+        return Promise.reject(new UniqueConstraintError());
+      });
 
       findSpy.onFirstCall().returns(Promise.resolve(null));
       findSpy.onSecondCall().returns(Promise.resolve(result));