Fix DataTypes.BOOLEAN toJSON bug

changelog.md

@@ -9,7 +9,8 @@
 - [BUG] Fixed empty where conditions in MySQL. [#619](https://github.com/sequelize/sequelize/pull/619). Thanks to terraflubb
 - [BUG] Fixed empty where conditions in MySQL. [#619](https://github.com/sequelize/sequelize/pull/619). Thanks to terraflubb
 - [BUG] Allow overriding of default columns. [#635](https://github.com/sequelize/sequelize/pull/635). Thanks to sevastos
 - [BUG] Allow overriding of default columns. [#635](https://github.com/sequelize/sequelize/pull/635). Thanks to sevastos
 - [BUG] Fix where params for belongsTo [#658](https://github.com/sequelize/sequelize/pull/658). Thanks to mweibel
 - [BUG] Fix where params for belongsTo [#658](https://github.com/sequelize/sequelize/pull/658). Thanks to mweibel
-- [BUG] Default ports are now declared in the connector manager, which means the default port for PG correctly becomes 5432. [#633](https://github.com/sequelize/sequelize/issues/633)
+- [BUG] Default ports are now declared in the connector manager, which means the default port for PG correctly becomes 5432. [#633](https://github.com/sequelize/sequelize/issues/633). durango
+- [BUG] Columns with type BOOLEAN were always added to toJSON output, even if they were not selected [see](https://gist.github.com/gchaincl/45aca14e93934bf4a05e). janmeier
 - [FEATURE] Validate a model before it gets saved. [#601](https://github.com/sequelize/sequelize/pull/601). thanks to durango
 - [FEATURE] Validate a model before it gets saved. [#601](https://github.com/sequelize/sequelize/pull/601). thanks to durango
 - [FEATURE] Schematics. [#564](https://github.com/sequelize/sequelize/pull/564). thanks to durango
 - [FEATURE] Schematics. [#564](https://github.com/sequelize/sequelize/pull/564). thanks to durango
 - [FEATURE] Foreign key constraints. [#595](https://github.com/sequelize/sequelize/pull/595). thanks to optilude
 - [FEATURE] Foreign key constraints. [#595](https://github.com/sequelize/sequelize/pull/595). thanks to optilude

lib/dao.js

@@ -308,7 +308,7 @@ module.exports = (function() {
     if (typeof this.dataValues[attribute] !== 'undefined')
     if (typeof this.dataValues[attribute] !== 'undefined')
       return;
       return;
 
 
-    if (this.booleanValues.length && this.booleanValues.indexOf(attribute) !== -1) // transform integer 0,1 into boolean
+    if (this.booleanValues.length && this.booleanValues.indexOf(attribute) !== -1 && value !== undefined) // transform integer 0,1 into boolean
       value = !!value;
       value = !!value;
 
 
     var has = (function(o) {
     var has = (function(o) {

spec/dao-factory.spec.js

@@ -860,6 +860,22 @@ describe(Helpers.getTestDialectTeaser("DAOFactory"), function() {
       })
       })
     })
     })
 
 
+    it("should not try to convert boolean values if they are not selected", function (done) {
+      var UserWithBoolean = this.sequelize.define('user', {
+        active: Sequelize.BOOLEAN
+      })
+
+      this.sequelize.sync({force: true}).success(function () {
+        UserWithBoolean.create({ active: true }).success(function (user) {
+          UserWithBoolean.find({ where: { id: user.id }, attributes: [ 'id' ] }).success(function (user) {
+            expect(user.active).not.toBeDefined()
+
+            done()
+          })
+        })
+      })
+    })
+
     it('finds a specific user via where option', function(done) {
     it('finds a specific user via where option', function(done) {
       this.User.find({ where: { username: 'barfooz' } }).success(function(user) {
       this.User.find({ where: { username: 'barfooz' } }).success(function(user) {
         expect(user.username).toEqual('barfooz')
         expect(user.username).toEqual('barfooz')