Merge pull request #1360 from thanpolas/expose-Validatior-Error

introduce the Sequelize signed Error Objects

lib/dao-validator.js

 var Validator = require("validator")
 var Validator = require("validator")
   , Utils     = require("./utils")
   , Utils     = require("./utils")
+  , sequelizeError = require("./errors")
 
 
 var DaoValidator = module.exports = function(model, options) {
 var DaoValidator = module.exports = function(model, options) {
   options = options || {}
   options = options || {}
@@ -27,7 +28,7 @@ DaoValidator.prototype.validate = function() {
         emitter.emit('success')
         emitter.emit('success')
       })
       })
       .error(function(err) {
       .error(function(err) {
-        var error = new Error('Validation error')
+        var error = new sequelizeError.ValidationError('Validation error')
         error[DaoValidator.RAW_KEY_NAME] = []
         error[DaoValidator.RAW_KEY_NAME] = []
 
 
         Utils._.each(err, function (value) {
         Utils._.each(err, function (value) {

lib/errors.js

+/**
+ * @fileOverview The Error Objects produced by Sequelize.
+ */
+
+var util = require('util')
+var error = module.exports = {}
+
+/**
+ * The Base Error all Sequelize Errors inherit from.
+ *
+ * @constructor
+ */
+error.BaseError = function() {
+  Error.call(this)
+};
+util.inherits(error.BaseError, Error)
+
+
+/**
+ * Validation Error
+ *
+ * @constructor
+ */
+error.ValidationError = function() {
+  error.BaseError.call(this)
+};
+util.inherits(error.ValidationError, error.BaseError)

lib/sequelize.js

@@ -8,6 +8,7 @@ var url                = require("url")
   , Transaction        = require("./transaction")
   , Transaction        = require("./transaction")
   , TransactionManager = require('./transaction-manager')
   , TransactionManager = require('./transaction-manager')
   , QueryTypes         = require('./query-types')
   , QueryTypes         = require('./query-types')
+  , sequelizeErrors    = require('./errors')
 
 
 module.exports = (function() {
 module.exports = (function() {
   /**
   /**
@@ -150,6 +151,15 @@ module.exports = (function() {
   })
   })
 
 
   /**
   /**
+   * Expose Sequelize Error types
+   */
+  Sequelize.prototype.Error = Sequelize.Error =
+    sequelizeErrors.BaseError
+  Sequelize.prototype.ValidationError = Sequelize.ValidationError =
+    sequelizeErrors.ValidationError
+
+
+  /**
    * Returns the specified dialect.
    * Returns the specified dialect.
    *
    *
    * @return {String} The specified dialect.
    * @return {String} The specified dialect.

test/error.test.js

+/* jshint camelcase: false */
+var chai      = require('chai')
+  , expect    = chai.expect
+  , Support   = require(__dirname + '/support')
+  , Sequelize = Support.Sequelize
+  // , sinon     = require('sinon')
+
+chai.Assertion.includeStack = true
+
+describe.only(Support.getTestDialectTeaser("Sequelize Errors"), function () {
+  describe('API Surface', function() {
+    it('Should have the Error constructors exposed', function() {
+      expect(Sequelize).to.have.property('Error')
+      expect(Sequelize).to.have.property('ValidationError')
+      var sequelize = new Sequelize();
+      expect(sequelize).to.have.property('Error')
+      expect(sequelize).to.have.property('ValidationError')
+    })
+    it('Sequelize Errors instances should be instances of Error', function() {
+      var error = new Sequelize.Error();
+      var validationError = new Sequelize.ValidationError();
+
+
+      var sequelize = new Sequelize();
+      var instError = new sequelize.Error();
+      var instValidationError = new sequelize.ValidationError();
+
+      expect(error).to.be.instanceOf(Error)
+      expect(validationError).to.be.instanceOf(Error)
+      expect(instError).to.be.instanceOf(Error)
+      expect(instValidationError).to.be.instanceOf(Error)
+    })
+  })
+})