perf: remove unnecessary cloneDeep calls (#11281)

lib/associations/has-many.js

@@ -180,7 +180,7 @@ class HasMany extends Association {
       instances = undefined;
       instances = undefined;
     }
     }
 
 
-    options = Utils.cloneDeep(options);
+    options = Object.assign({}, options);
 
 
     if (this.scope) {
     if (this.scope) {
       Object.assign(where, this.scope);
       Object.assign(where, this.scope);

lib/model.js

@@ -1689,7 +1689,6 @@ class Model {
     this.warnOnInvalidOptions(options, Object.keys(this.rawAttributes));
     this.warnOnInvalidOptions(options, Object.keys(this.rawAttributes));
 
 
     const tableNames = {};
     const tableNames = {};
-    let originalOptions;
 
 
     tableNames[this.getTableName(options)] = true;
     tableNames[this.getTableName(options)] = true;
     options = Utils.cloneDeep(options);
     options = Utils.cloneDeep(options);
@@ -1751,9 +1750,8 @@ class Model {
         return this.runHooks('beforeFindAfterOptions', options);
         return this.runHooks('beforeFindAfterOptions', options);
       }
       }
     }).then(() => {
     }).then(() => {
-      originalOptions = Utils.cloneDeep(options);
-      options.tableNames = Object.keys(tableNames);
-      return this.QueryInterface.select(this, this.getTableName(options), options);
+      const selectOptions = Object.assign({}, options, { tableNames: Object.keys(tableNames) });
+      return this.QueryInterface.select(this, this.getTableName(selectOptions), selectOptions);
     }).tap(results => {
     }).tap(results => {
       if (options.hooks) {
       if (options.hooks) {
         return this.runHooks('afterFind', results, options);
         return this.runHooks('afterFind', results, options);
@@ -1771,7 +1769,7 @@ class Model {
         throw new sequelizeErrors.EmptyResultError();
         throw new sequelizeErrors.EmptyResultError();
       }
       }
 
 
-      return Model._findSeparate(results, originalOptions);
+      return Model._findSeparate(results, options);
     });
     });
   }
   }
 
 

lib/query-interface.js

@@ -1112,10 +1112,8 @@ class QueryInterface {
     );
     );
   }
   }
 
 
-  select(model, tableName, options) {
-    options = Utils.cloneDeep(options);
-    options.type = QueryTypes.SELECT;
-    options.model = model;
+  select(model, tableName, optionsArg) {
+    const options = Object.assign({}, optionsArg, { type: QueryTypes.SELECT, model });
 
 
     return this.sequelize.query(
     return this.sequelize.query(
       this.QueryGenerator.selectQuery(tableName, options, model),
       this.QueryGenerator.selectQuery(tableName, options, model),