[model/bulkCreate] don't fail on blank arrays (fixes #1148)

lib/dao-factory.js

@@ -688,6 +688,12 @@ module.exports = (function() {
     Utils.validateParameter(fieldsOrOptions, Object, { deprecated: Array, optional: true, index: 2, method: 'DAOFactory#bulkCreate' })
     Utils.validateParameter(fieldsOrOptions, Object, { deprecated: Array, optional: true, index: 2, method: 'DAOFactory#bulkCreate' })
     Utils.validateParameter(options, 'undefined', { deprecated: Object, optional: true, index: 3, method: 'DAOFactory#bulkCreate' })
     Utils.validateParameter(options, 'undefined', { deprecated: Object, optional: true, index: 3, method: 'DAOFactory#bulkCreate' })
 
 
+    if (!records.length) {
+      return new Utils.CustomEventEmitter(function(emitter) {
+        emitter.emit('success', [])
+      }).run();
+    }
+
     options = Utils._.extend({
     options = Utils._.extend({
       validate: false,
       validate: false,
       hooks: false
       hooks: false

test/dao-factory/create.test.js

@@ -883,6 +883,18 @@ describe(Support.getTestDialectTeaser("DAOFactory"), function () {
       })
       })
     })
     })
 
 
+    it('should allow blank arrays (return immediatly)', function (done) {
+      var Worker = this.sequelize.define('Worker', {})
+      Worker.sync().done(function(err) { 
+        Worker.bulkCreate([]).done(function (err, workers) {
+          expect(err).not.to.be.ok
+          expect(workers).to.be.ok
+          expect(workers.length).to.equal(0)
+          done()
+        })
+      })
+    })
+
     it('should allow blank creates (with timestamps: false)', function (done) {
     it('should allow blank creates (with timestamps: false)', function (done) {
       var Worker = this.sequelize.define('Worker', {}, {timestamps: false})
       var Worker = this.sequelize.define('Worker', {}, {timestamps: false})
       Worker.sync().done(function(err) { 
       Worker.sync().done(function(err) {