[ci skip] Add deprecation notice to eventemitter fcts on promise

lib/promise.js

@@ -104,6 +104,8 @@ SequelizePromise.all = function (promises) {
  *
  *
  * @param {String} evt
  * @param {String} evt
  * @param {Function} fct
  * @param {Function} fct
+ *
+ * @deprecated
  */
  */
 Promise.prototype.on = function(evt, fct) {
 Promise.prototype.on = function(evt, fct) {
   if (evt === 'success') {
   if (evt === 'success') {
@@ -123,6 +125,8 @@ Promise.prototype.on = function(evt, fct) {
  * Emit an event from the emitter
  * Emit an event from the emitter
  * @param {string} type The type of event
  * @param {string} type The type of event
  * @param {any}    value(s)* All other arguments will be passed to the event listeners
  * @param {any}    value(s)* All other arguments will be passed to the event listeners
+ *
+ * @deprecated
  */
  */
 Promise.prototype.emit = function(evt) {
 Promise.prototype.emit = function(evt) {
   var args = arguments.length > 1 ? Array.prototype.slice.call(arguments, 1) : [];
   var args = arguments.length > 1 ? Array.prototype.slice.call(arguments, 1) : [];
@@ -159,6 +163,8 @@ Promise.prototype.emit = function(evt) {
  * @method success
  * @method success
  * @alias ok
  * @alias ok
  * @return this
  * @return this
+ *
+ * @deprecated
  */
  */
 Promise.prototype.success =
 Promise.prototype.success =
 Promise.prototype.ok = function(fct) {
 Promise.prototype.ok = function(fct) {
@@ -184,6 +190,8 @@ Promise.prototype.ok = function(fct) {
  * @alias fail
  * @alias fail
  * @alias failure
  * @alias failure
  * @return this
  * @return this
+ *
+ * @deprecated
  */
  */
 Promise.prototype.error =
 Promise.prototype.error =
 Promise.prototype.failure =
 Promise.prototype.failure =
@@ -205,6 +213,8 @@ Promise.prototype.fail = function(fct) {
 * @method done
 * @method done
 * @alias complete
 * @alias complete
 * @return this
 * @return this
+*
+* @deprecated done(fct) is deprecated, done() is regular promise syntax to explicitly signal the end of a promise chain and will not be deprecated
 */
 */
 var bluebirdDone = Promise.prototype.done;
 var bluebirdDone = Promise.prototype.done;
 Promise.prototype.done =
 Promise.prototype.done =
@@ -243,6 +253,8 @@ Promise.prototype.sql = function(fct) {
  * @param  {Object}           [options]
  * @param  {Object}           [options]
  * @param  {Array}            [options.events] An array of the events to proxy. Defaults to sql, error and success
  * @param  {Array}            [options.events] An array of the events to proxy. Defaults to sql, error and success
  * @return this
  * @return this
+ *
+ * @deprecated
  */
  */
 Promise.prototype.proxy = function(promise, options) {
 Promise.prototype.proxy = function(promise, options) {
   options = Utils._.extend({
   options = Utils._.extend({