Skip to content
Toggle navigation
Projects
Groups
Snippets
Help
public
/
sequelize
This project
Loading...
Sign in
Toggle navigation
Go to a project
Project
Repository
Issues
0
Merge Requests
0
Pipelines
Wiki
Snippets
Settings
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
不要怂,就是干,撸起袖子干!
Commit c90c8d5c
authored
Jul 14, 2018
by
u9r52sld
Committed by
Sushant
Jul 14, 2018
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
fix: throw when type of array values is not defined (#9649)
1 parent
fea6db4a
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
17 additions
and
2 deletions
lib/sequelize.js
test/integration/sequelize.test.js
lib/sequelize.js
View file @
c90c8d5
...
...
@@ -1095,9 +1095,14 @@ class Sequelize {
type
=
dialectTypes
[
type
.
key
].
extend
(
type
);
}
if
(
type
instanceof
DataTypes
.
ARRAY
&&
dialectTypes
[
type
.
type
.
key
])
{
type
.
type
=
dialectTypes
[
type
.
type
.
key
].
extend
(
type
.
type
);
if
(
type
instanceof
DataTypes
.
ARRAY
)
{
if
(
!
type
.
type
)
{
throw
new
Error
(
'ARRAY is missing type definition for its values.'
);
}
else
if
(
dialectTypes
[
type
.
type
.
key
])
{
type
.
type
=
dialectTypes
[
type
.
type
.
key
].
extend
(
type
.
type
);
}
}
return
type
;
}
...
...
test/integration/sequelize.test.js
View file @
c90c8d5
...
...
@@ -1206,6 +1206,16 @@ describe(Support.getTestDialectTeaser('Sequelize'), () => {
});
describe
(
'define'
,
()
=>
{
it
(
'raises an error if no values are defined'
,
function
()
{
expect
(()
=>
{
this
.
sequelize
.
define
(
'omnomnom'
,
{
bla
:
{
type
:
DataTypes
.
ARRAY
}
});
}).
to
.
throw
(
Error
,
'ARRAY is missing type definition for its values.'
);
});
});
describe
(
'define'
,
()
=>
{
[
{
type
:
DataTypes
.
ENUM
,
values
:
[
'scheduled'
,
'active'
,
'finished'
]},
DataTypes
.
ENUM
(
'scheduled'
,
'active'
,
'finished'
)
...
...
Write
Preview
Markdown
is supported
Attach a file
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to post a comment