feat: pass uri query parameters to dialectOptions (#10025)

lib/sequelize.js

@@ -105,7 +105,7 @@ class Sequelize {
       config = {};
       options = username || {};
 
-      const urlParts = url.parse(arguments[0]);
+      const urlParts = url.parse(arguments[0], true);
 
       options.dialect = urlParts.protocol.replace(/:$/, '');
       options.host = urlParts.hostname;
@@ -131,6 +131,13 @@ class Sequelize {
         if (authParts.length > 1)
           config.password = authParts.slice(1).join(':');
       }
+
+      if (urlParts.query) {
+        if (options.dialectOptions)
+          _.assign(options.dialectOptions, urlParts.query);
+        else
+          options.dialectOptions = urlParts.query;
+      }
     } else {
       // new Sequelize(database, username, password, { ... options })
       options = options || {};

test/unit/configuration.test.js

@@ -153,5 +153,30 @@ describe('Sequelize', () => {
 
       expect(config.port).to.equal(port);
     });
+
+    it('should pass query string parameters to dialectOptions', () => {
+      const sequelize = new Sequelize('mysql://example.com:9821/dbname?ssl=true');
+      const dialectOptions = sequelize.config.dialectOptions;
+
+      expect(dialectOptions.ssl).to.equal('true');
+    });
+
+    it('should merge query string parameters to options', () => {
+      const sequelize = new Sequelize('mysql://example.com:9821/dbname?ssl=true&application_name=client', {
+        storage: '/completely/different/path.db',
+        dialectOptions: {
+          supportBigNumbers: true,
+          application_name: 'server',
+        }
+      });
+
+      const options = sequelize.options;
+      const dialectOptions = sequelize.config.dialectOptions;
+
+      expect(options.storage).to.equal('/completely/different/path.db');
+      expect(dialectOptions.supportBigNumbers).to.be.true;
+      expect(dialectOptions.application_name).to.equal('client');
+      expect(dialectOptions.ssl).to.equal('true');
+    });
   });
 });