fix(error): optimistic lock message (#10068)

lib/errors/index.js

@@ -92,7 +92,7 @@ class OptimisticLockError extends BaseError {
   constructor(options) {
     options = options || {};
     options.message = options.message || `Attempting to update a stale model instance: ${options.modelName}`;
-    super(options);
+    super(options.message);
     this.name = 'SequelizeOptimisticLockError';
     /**
      * The name of the model on which the update was attempted

test/integration/error.test.js

@@ -242,7 +242,36 @@ describe(Support.getTestDialectTeaser('Sequelize Errors'), () => {
     });
   });
 
-  describe('Constraint error', () => {
+  describe('OptimisticLockError', () => {
+    it('got correct error type and message', function() {
+      const Account = this.sequelize.define('Account', {
+        number: {
+          type: Sequelize.INTEGER
+        }
+      }, {
+        version: true
+      });
+
+      return Account.sync({force: true}).then(() => {
+        const result = Account.create({number: 1}).then(accountA => {
+          return Account.findByPk(accountA.id).then(accountB => {
+            accountA.number += 1;
+            return accountA.save().then(() => { return accountB; });
+          });
+        }).then(accountB => {
+          accountB.number += 1;
+          return accountB.save();
+        });
+
+        return Promise.all([
+          expect(result).to.eventually.be.rejectedWith(Support.Sequelize.OptimisticLockError),
+          expect(result).to.eventually.be.rejectedWith('Attempting to update a stale model instance: Account')
+        ]);
+      });
+    });
+  });
+
+  describe('ConstraintError', () => {
     [
       {
         type: 'UniqueConstraintError',