不要怂,就是干,撸起袖子干!

Commit fe7703c6 by Sascha Depold

Merge pull request #446 from clkao/todo-tests

mark all known dialect-specific failing tests as todo with itEventually
2 parents 99a6d3c5 c25e8f46
...@@ -11,6 +11,7 @@ buster.testRunner.timeout = 500 ...@@ -11,6 +11,7 @@ buster.testRunner.timeout = 500
describe(Helpers.getTestDialectTeaser("BelongsTo"), function() { describe(Helpers.getTestDialectTeaser("BelongsTo"), function() {
before(function(done) { before(function(done) {
Helpers.initTests({ Helpers.initTests({
dialect: dialect,
beforeComplete: function(sequelize) { beforeComplete: function(sequelize) {
this.sequelize = sequelize this.sequelize = sequelize
}.bind(this), }.bind(this),
......
...@@ -352,7 +352,7 @@ describe(Helpers.getTestDialectTeaser("DAOFactory"), function() { ...@@ -352,7 +352,7 @@ describe(Helpers.getTestDialectTeaser("DAOFactory"), function() {
}) })
}) })
it('stores the current date in createdAt', function(done) { ;(dialect.match(/^postgres/) ? itEventually : it)('stores the current date in createdAt', function(done) {
this.User.create({ username: 'foo' }).success(function(user) { this.User.create({ username: 'foo' }).success(function(user) {
expect(parseInt(+user.createdAt/5000)).toEqual(parseInt(+new Date()/5000)) expect(parseInt(+user.createdAt/5000)).toEqual(parseInt(+new Date()/5000))
done() done()
......
...@@ -121,7 +121,7 @@ describe(Helpers.getTestDialectTeaser("Migrator"), function() { ...@@ -121,7 +121,7 @@ describe(Helpers.getTestDialectTeaser("Migrator"), function() {
}) })
}) })
it("executes migration #20111117063700 and correctly adds isBetaMember", function(done) { ;(dialect === 'sqlite' ? itEventually : it)("executes migration #20111117063700 and correctly adds isBetaMember", function(done) {
this.sequelize.getQueryInterface().describeTable('Person').success(function(data) { this.sequelize.getQueryInterface().describeTable('Person').success(function(data) {
var fields = data.map(function(d) { return d.Field }).sort() var fields = data.map(function(d) { return d.Field }).sort()
expect(fields).toEqual([ 'isBetaMember', 'name' ]) expect(fields).toEqual([ 'isBetaMember', 'name' ])
...@@ -167,7 +167,7 @@ describe(Helpers.getTestDialectTeaser("Migrator"), function() { ...@@ -167,7 +167,7 @@ describe(Helpers.getTestDialectTeaser("Migrator"), function() {
}.bind(this)) }.bind(this))
}) })
it("executes migration #20111205064000 and renames a table", function(done) { ;(dialect === 'sqlite' ? itEventually : it)("executes migration #20111205064000 and renames a table", function(done) {
this.sequelize.getQueryInterface().showAllTables().success(function(tableNames) { this.sequelize.getQueryInterface().showAllTables().success(function(tableNames) {
tableNames = tableNames.filter(function(e){ return e != 'SequelizeMeta' }) tableNames = tableNames.filter(function(e){ return e != 'SequelizeMeta' })
expect(tableNames).toEqual([ 'Person' ]) expect(tableNames).toEqual([ 'Person' ])
...@@ -213,7 +213,7 @@ describe(Helpers.getTestDialectTeaser("Migrator"), function() { ...@@ -213,7 +213,7 @@ describe(Helpers.getTestDialectTeaser("Migrator"), function() {
}) })
describe('removeColumn', function() { describe('removeColumn', function() {
it('removes the shopId column from user', function(done) { (dialect === 'mysql' ? it : itEventually)('removes the shopId column from user', function(done) {
this.init({ to: 20111206061400 }, function(migrator) { this.init({ to: 20111206061400 }, function(migrator) {
migrator.migrate().success(function(){ migrator.migrate().success(function(){
this.sequelize.getQueryInterface().describeTable('User').success(function(data) { this.sequelize.getQueryInterface().describeTable('User').success(function(data) {
...@@ -238,7 +238,7 @@ describe(Helpers.getTestDialectTeaser("Migrator"), function() { ...@@ -238,7 +238,7 @@ describe(Helpers.getTestDialectTeaser("Migrator"), function() {
}) })
describe('changeColumn', function() { describe('changeColumn', function() {
it('changes the signature column from user to default "signature" + notNull', function(done) { (dialect === 'mysql' ? it : itEventually)('changes the signature column from user to default "signature" + notNull', function(done) {
this.init({ to: 20111206063000 }, function(migrator) { this.init({ to: 20111206063000 }, function(migrator) {
migrator.migrate().success(function() { migrator.migrate().success(function() {
this.sequelize.getQueryInterface().describeTable('User').success(function(data) { this.sequelize.getQueryInterface().describeTable('User').success(function(data) {
...@@ -258,7 +258,7 @@ describe(Helpers.getTestDialectTeaser("Migrator"), function() { ...@@ -258,7 +258,7 @@ describe(Helpers.getTestDialectTeaser("Migrator"), function() {
}) })
describe('renameColumn', function() { describe('renameColumn', function() {
it("renames the signature column from user to sig", function(done) { (dialect === 'mysql' ? it : itEventually)("renames the signature column from user to sig", function(done) {
this.init({ to: 20111206163300 }, function(migrator) { this.init({ to: 20111206163300 }, function(migrator) {
migrator.migrate().success(function(){ migrator.migrate().success(function(){
this.sequelize.getQueryInterface().describeTable('User').success(function(data) { this.sequelize.getQueryInterface().describeTable('User').success(function(data) {
......
Markdown is supported
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!