public / sequelize

* (docs/docs/associations.md) punctuation fix - added comma

* (docs/docs/associations.md) punctuation fix - added comma

* (docs/docs/associations.md) grammar correction

* Pass options to MSSQL removeColumn queries

* [ci skip] Added changelog entry

* Review fixes - Use Object.assign instead of lodash assign

* Update changelog description

* fix ER_EMPTY_QUERY error on update with virtual fields for master

* fix review

* [ci skip] Changelog for #6356

* Fixes creation of polymorphic belongToMany associations in one step

* Fix test failure for MSSQL

* Fix tests

* Fix `Instance.decrement` precision problems

* [ci skip] Link to issue

* Throw an error when attribute options are not formatted correctly

* remove space

* update changelong

* Tedious debug undefined dialectOptions fix

* Added PR link to changelog

v3: sourceKey feature for hasMany doesn't work if where clause specified in include (#7141) (#7147)

* Initial Commit

* Stops test from removing test/integration/assets/es6project.js

* Fixes impromper syntax when specifying the use of association.sourceIdentifier or left.primaryKeyAttribute for attrLeft. Also includes integration test.

* Updates changelog.

* Adds link to issue in changelog entry.

* Added 'Future' header to changelog entry

* Removed changelog update as requested.

* Updates changelog. Fixes query-generator to properly build queries from hasMany even with an include while respecting a specified sourceKey. Adds an integration test.

* Added back removed whitespace per request.

* Updates test in include altered field name in source key. Fixes were then made to address the test breaking. All tests pass now.

* Adds back removed whitespace.

* MSSQL - Skip isolationLevel query, enable tedious debugging

* Added changelog entry, updated docs

* generic pool update and other fixes

* connection internally removed

* doc entry

* review changes

* pooling changes

* Added getPrimaryKeyConstraint method to drop primarykey constraint before dropping primarykey column

* Added changelog entry, exclude primaryKey constraint for mysql removeColumn method

* Review fixes

* Fixes failing test

* Enabled filtered indexes for SQL Server

* [ci skip] Added filtered indexes to docs/migrations.md

* add failing unit test

* use .slice instead of .splice to get arguments for scope functions

* add message to changelog.md

* fix: use paranoid with groupedLimit.on association

* logging and unstable test

* eslint changes

* Update belongs-to-many.js

https://greenkeeper.io/

* added validation checks for findall

* unittest input validations checking code for findall

* es6 changes function to =>

* trailing whitespace

* remove unnecessary use of bind given es6 => funcs

* update changelog and fix jshint errors

* fix changelog

* add test to make sure findall calls input validation function

* remove only from test

* remove generic invalid option support and only apply for model attributes

* Add missing period.

* Remove extra "here"

* rewrite logic for finding associations

* update and add new error messgaes and change existing tests to match

* remove comments

* tighten up code for getting associations and keep support for node4

* create SequelizeEagerLoadingError

* remove spaces

* added some happy path unit tests for _getIncludedAssociation

* updated the change log

* remove only

* associations with duplicate aliases are not allowed

* add semi-colon

* place hasAlias in more sensible locatio

* added hasAlias tests

* added association tests for duplicate aliases

* remove unused require

* update changeload

* small formatting changes

* add missing parameter

* remove some basic setup from each association and add to constructor

* add regression tests for improperly constructed belongsToMany associations

* use single quote strings and small const fix

* eslint fixes

* small refactor

* jshint promise expception added

* [MSSQL] MERGE statement foreignKey violation is formatted as ForeignKeyConstraintError, Closes #7011

* Added changelog entry

* Alter changelog entry

* [ci skip] link to issue

* rewrite logic for finding associations

* update and add new error messgaes and change existing tests to match

* remove comments

* tighten up code for getting associations and keep support for node4

* create SequelizeEagerLoadingError

* remove spaces

* added some happy path unit tests for _getIncludedAssociation

* updated the change log

* remove only

* [MSSQL] Uses crypto randomBytes to generate 20 character trasaction identifier, enabled trasaction tests for mssql dialect

* Added missing break, changelog entry

* Added READ_COMMITTED_SNAPSHOT ON script for tests, fixes skipped tests, transaction savepoints, uses sequelize_test as default database on appveyor

* Added sqlcmd database query to appveyor-setup.ps1

* Added sequelize_test as default db in test/config/config for MSSQL dialect

* Moved READ_COMMITTED_SNAPSHOT ON query to appveyor ps script

* Replaced lodash includes with startsWith, review fixes, closes #6954

* try catch block added for formatting parameters process

* new line space added before braces

* query function processing wrapped to Promise.try

* processQuery method removed from var

* binding context changed to arrow function

* promise.try chaining added

* extra Promise.resolve removed code refactored

* space added

* test cases for 'query' method updated with respect to new rejection structure instead of throwing error

* it block messages corrected

* return added and code structured

* line space added

* line space added

* code style fixed

* Update hooks.js

Fixed error where `return` was called inside of a for loop. 
This prevented execution of more than one synchronous hook.

* Added tests for before/afterInit and before/afterDefine hooks

* sooo many new lines 🔥

* fixes for MSSQL bulkInsetQuery unit test edge cases and add large integration test

* put back es6project.js

* Revert "temporary fork to add upsert to mssql until we upgrade sequelize"

This reverts commit 14d73a0a958efd981d51a9439579fd2b00698cfa.

* update changelog

* fix up changelog

* space - review comment

* use const in master

* es6 updates

* more es6 updates

* quotes