- 10 Dec, 2014 40 commits
-
-
There are more than one error messages related to unique constraints that we need to catch. This closes one more broken test, in ancitipation of the crate table refactoring which closes the other.
Matt Broadstone committed -
There is no need to use the mssql wrapped around tedious, and switching to the lower level module allows better integration as well as bypassing the mssql forced connection pooling
Matt Broadstone committed -
Matt Broadstone committed
-
Code was merged into master to allow modification of the abstract dialect to support mssql specific cases. This removes the custom implementations
Matt Broadstone committed -
Matt Broadstone committed
-
This is more of a stylistic change, as no functional behavior differs, however it makes diagnostics much easier and is theoretically faster than the previous select code.
Matt Broadstone committed -
Matt Broadstone committed
-
MSSQL doesn't support RESTRICT foreign key constraints at all, so there's no use running any of those tests
Matt Broadstone committed -
This is completely broken anyway, these tests are being used to conditionally report back false positives for transaction support.
Matt Broadstone committed -
- modify the returned sql for isolation level - remove some commented out code - cheat a little by reordering tests (look into this)
Matt Broadstone committed -
- major deletion of code duplication - cleaned up code (removed duplicate documentation) - moved a lot of SqlGenerator sql back into QueryGenerator
Matt Broadstone committed -
Matt Broadstone committed
-
Matt Broadstone committed
-
- missed a case for addLimitAndOffset for subqueries with a single model - formatResults should return undefined if there is no data - there are a few possible error messages in an invalid connection scenario
Matt Broadstone committed -
- bring addIndexQuery in line with abstract dialect - use an improved method for showing indices with sp_helpindex - actually use handleShowIndexQuery (bringing us closer to the abstract dialect for formatResults) - temporarily disable tests for a FULLTEXT index
Matt Broadstone committed -
Matt Broadstone committed
-
Matt Broadstone committed
-
Matt Broadstone committed
-
DataTypes.DATE was set to "DATETIME2", which has implications for internal sequelize code. Instead we should be using a data type mapping, like postgres support.
Matt Broadstone committed -
Matt Broadstone committed
-
Matt Broadstone committed
-
Matt Broadstone committed
-
VIRTUAL attributes were accidentally being included in INSERT and UPDATE statements as OUTPUT variables
Matt Broadstone committed -
Matt Broadstone committed
-
Bulk insertions were refactored to prefer row construction for bulk inserts that are not empty. The actual sql generation was moved back into the query-generator, and removed from sql-generator. Also a number of console.log and console.warn's were moved over to using sequelize's internal logging mechanism
Matt Broadstone committed -
There a whole bunch wrong here, but mostly with sequelize. First and foremost attributeToSQL (the convention) should be working with attributes, however it's using dataTypes here because.. well every other dialect does this too. addColumnQuery as defined in the abstract QueryGenerator class says you should be using attributes, but everyone else uses (key, dataType). This is a kludge to make ENUMs work for TSQL, since it needs to know the field name to generate the SQL
Matt Broadstone committed -
The existing timestamp test checked the values within 50ms of each other, since 50ms was a realistic latency for the existing test framework (locally on travis with pg, mysql, etc). The mssql tests generally take much longer, but this solution accounts for both and future cases.
Matt Broadstone committed -
The MSSQL dialect implements its own sql generator, and was accidentally adding an extra raw attribute for an aliased field
Matt Broadstone committed -
Joel Trost committed
-
Joel Trost committed
-
Joel Trost committed
-
Joel Trost committed
-
Joel Trost committed
-
Joel Trost committed
-
Joel Trost committed
-
Joel Trost committed
-
Joel Trost committed
-
Joel Trost committed
-
Joel Trost committed
-
Joel Trost committed
-